From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Marc Marí" <marc.mari.barcelo@gmail.com>,
"Fam Zheng" <famz@redhat.com>,
"Stefan Hajnoczi" <stefanha@gmail.com>,
"Jason Wang" <jasowang@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH RFC for-2.2] virtio-blk: force 1st s/g to match header
Date: Mon, 1 Dec 2014 14:18:43 +0200 [thread overview]
Message-ID: <20141201121843.GC17505@redhat.com> (raw)
In-Reply-To: <CAFEAcA_XmeNF=xWNJ4ozJRT4cQwyUPbFL_eX8Jqh1L1uabXcmw@mail.gmail.com>
On Mon, Dec 01, 2014 at 12:07:07PM +0000, Peter Maydell wrote:
> On 30 November 2014 at 16:43, Michael S. Tsirkin <mst@redhat.com> wrote:
> > The result of this is host mapping leak.
> > What effect does this have? Can this DOS host?
>
> I don't think we can DOS the host here.
>
> If Xen, we crash (but you can't use virtio-blk with Xen anyway)
> Otherwise, if you managed to get address_space_map() to hand you
> the bounce-buffer (by asking for dma to something other than RAM)
> then we'll either hit an assertion or just end up never allowing
> dma to/from non-RAM ever again for this guest.
> The usual case would be that this was dma to/from ram, in
> which case it's harmless if the virtio-backend never wrote to
> the memory, and will fail to update dirty bitmaps for migration
> etc if the backend did write.
>
> In any case I think that none of these outcomes are worse
> than the "exit(1)" the current patch proposes.
>
> -- PMM
Fair enough.
Pls disregard the patch then, and we'll fix it properly
for 2.3 when we set ANY_LAYOUT.
prev parent reply other threads:[~2014-12-01 12:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 16:33 [Qemu-devel] [PATCH RFC for-2.2] virtio-blk: force 1st s/g to match header Michael S. Tsirkin
2014-11-27 19:21 ` Stefan Hajnoczi
2014-11-27 21:13 ` Michael S. Tsirkin
2014-11-28 1:16 ` Fam Zheng
2014-11-28 7:05 ` Jason Wang
2014-11-28 11:43 ` Stefan Hajnoczi
2014-11-28 14:05 ` Marc Marí
2014-11-28 16:14 ` Peter Maydell
2014-11-30 16:43 ` Michael S. Tsirkin
2014-12-01 12:07 ` Peter Maydell
2014-12-01 12:18 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141201121843.GC17505@redhat.com \
--to=mst@redhat.com \
--cc=famz@redhat.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=marc.mari.barcelo@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).