From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvRXw-0001fo-W0 for qemu-devel@nongnu.org; Mon, 01 Dec 2014 09:01:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XvRXs-0005OK-4D for qemu-devel@nongnu.org; Mon, 01 Dec 2014 09:01:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvRXr-0005OG-SS for qemu-devel@nongnu.org; Mon, 01 Dec 2014 09:01:44 -0500 Date: Mon, 1 Dec 2014 14:01:40 +0000 From: Stefan Hajnoczi Message-ID: <20141201140140.GC6744@stefanha-thinkpad.redhat.com> References: <1417091366-4469-1-git-send-email-stefanha@redhat.com> <1417091366-4469-5-git-send-email-stefanha@redhat.com> <20141127162905.GG2583@work-vm> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nmemrqcdn5VTmUEE" Content-Disposition: inline In-Reply-To: <20141127162905.GG2583@work-vm> Subject: Re: [Qemu-devel] [RFC 4/6] migration: move dirty bitmap sync to ram_addr.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" Cc: Peter Maydell , rth@redhat.com, qemu-devel@nongnu.org, Juan Quintela , Paolo Bonzini --nmemrqcdn5VTmUEE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 27, 2014 at 04:29:06PM +0000, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefanha@redhat.com) wrote: > > The dirty memory bitmap is managed by ram_addr.h and copied to > > migration_bitmap[] periodically during live migration. > >=20 > > Move the code to sync the bitmap to ram_addr.h where related code lives. >=20 > Is this sync code going to need to gain a barrier (although I'm not quite > sure which) to ensure it's picked up all changes? gcc makes these operations a full barrier: https://gcc.gnu.org/onlinedocs/gcc-4.1.1/gcc/Atomic-Builtins.html Stefan --nmemrqcdn5VTmUEE Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUfHTEAAoJEJykq7OBq3PIXr0H/2BUM/zxk25zEYf98t7Wz3B8 5hrk00mBARzHGkKcSegwuYfQWzUMiAfnPTAeX6miCAZs9lka0gtd1a3/mVdIjSHT G5PGHhl2FEUZ1mp9gByHr0OElHsIiamlfUyo7rnvY+s2WdFhMnnN+O5cNuInhw96 TRz7SRB2+NemF2CTr+dU02FjlJ0WKOXgz4TOfk4wkKZk/TWbiMmY7sF6eHERSgRY tMeVXFdWim2iHb/9612ZF/XHutifvQtYO7ybcin2g+ie+BBobiKIV3BqAHN6Ucq4 BK6EN9d19DlP9CuFESMtlNlh5TlTt8EbglxIO6M7mAIhUyeZiJ1V39E1Yf4ymRw= =2sQ8 -----END PGP SIGNATURE----- --nmemrqcdn5VTmUEE--