[Qemu-devel] Vhost-user - multi queue support

[Qemu-devel] Vhost-user - multi queue support

[Long, Thomas]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Hi All,
I'm just wondering what the status is with regards to supporting multi-queue in Vhost-user?

I see that Nikolaev has developed a patch to support this feature:
https://github.com/SnabbCo/qemu/commit/f41eeccf4ab6ea5970e2941ce2de0aae893b10f9

Are there any current plans to pull either this patch or a different patch into QEMU ?

Regards,
Tommy


[-- Attachment #2: Type: text/html, Size: 2843 bytes --]

Re: [Qemu-devel] Vhost-user - multi queue support

[Michael S. Tsirkin]

On Tue, Dec 02, 2014 at 11:42:22AM +0000, Long, Thomas wrote:
> Hi All,
> 
> I’m just wondering what the status is with regards to supporting multi-queue in
> Vhost-user?
> 
>  
> 
> I see that Nikolaev has developed a patch to support this feature:
> 
> https://github.com/SnabbCo/qemu/commit/f41eeccf4ab6ea5970e2941ce2de0aae893b10f9
> 
>  
> 
> Are there any current plans to pull either this patch or a different patch into
> QEMU ?
> 
>  
> 
> Regards,
> 
> Tommy
> 
>  
> 

I don't think it was every submitted.

Re: [Qemu-devel] Vhost-user - multi queue support

[Olivier MATZ]

Hi All,

On 12/02/2014 01:24 PM, Michael S. Tsirkin wrote:
> On Tue, Dec 02, 2014 at 11:42:22AM +0000, Long, Thomas wrote:
>> Hi All,
>>
>> I’m just wondering what the status is with regards to supporting multi-queue in
>> Vhost-user?
>>
>> I see that Nikolaev has developed a patch to support this feature:
>>
>> https://github.com/SnabbCo/qemu/commit/f41eeccf4ab6ea5970e2941ce2de0aae893b10f9
>>
>> Are there any current plans to pull either this patch or a different patch into
>> QEMU ?

I reviewed the patch and it looks good to me. One small comment: if
nc->info_str is set to ("vhost-user%d to %s", i, chr->label), it would
make sense to display it when the event callback:

--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -122,36 +122,39 @@ static void net_vhost_user_event(void *opaque, int 
event)
      case CHR_EVENT_OPENED:
          vhost_user_start(s);
          net_vhost_link_down(s, false);
-        error_report("chardev \"%s\" went up\n", s->chr->label);
+        error_report("chardev \"%s\" went up\n", s->nc.info_str);
          break;
      case CHR_EVENT_CLOSED:
          net_vhost_link_down(s, true);
          vhost_user_stop(s);
-        error_report("chardev \"%s\" went down\n", s->chr->label);
+        error_report("chardev \"%s\" went down\n", s->nc.info_str);
          break;
      }
  }


If it helps, I can submit a patch based on Nikolaev's on the list.

Regards,
Olivier

Re: [Qemu-devel] Vhost-user - multi queue support

[Long, Thomas]

-----Original Message-----
From: Olivier MATZ [mailto:olivier.matz@6wind.com] 
Sent: Tuesday, December 2, 2014 4:41 PM
To: Michael S. Tsirkin; Long, Thomas
Cc: Ryan, Brendan; qemu-devel@nongnu.org; n.nikolaev@virtualopensystems.com
Subject: Re: [Qemu-devel] Vhost-user - multi queue support

Hi All,

On 12/02/2014 01:24 PM, Michael S. Tsirkin wrote:
> On Tue, Dec 02, 2014 at 11:42:22AM +0000, Long, Thomas wrote:
>> Hi All,
>>
>> I’m just wondering what the status is with regards to supporting 
>> multi-queue in Vhost-user?
>>
>> I see that Nikolaev has developed a patch to support this feature:
>>
>> https://github.com/SnabbCo/qemu/commit/f41eeccf4ab6ea5970e2941ce2de0a
>> ae893b10f9
>>
>> Are there any current plans to pull either this patch or a different 
>> patch into QEMU ?

I reviewed the patch and it looks good to me. One small comment: if
nc->info_str is set to ("vhost-user%d to %s", i, chr->label), it would
make sense to display it when the event callback:

--- a/net/vhost-user.c
+++ b/net/vhost-user.c
@@ -122,36 +122,39 @@ static void net_vhost_user_event(void *opaque, int
event)
      case CHR_EVENT_OPENED:
          vhost_user_start(s);
          net_vhost_link_down(s, false);
-        error_report("chardev \"%s\" went up\n", s->chr->label);
+        error_report("chardev \"%s\" went up\n", s->nc.info_str);
          break;
      case CHR_EVENT_CLOSED:
          net_vhost_link_down(s, true);
          vhost_user_stop(s);
-        error_report("chardev \"%s\" went down\n", s->chr->label);
+        error_report("chardev \"%s\" went down\n", s->nc.info_str);
          break;
      }
  }


If it helps, I can submit a patch based on Nikolaev's on the list.

[TL] - Olivier it would be great if you could do that assuming there are no objections from anyone ?

Regards,
Olivier

Re: [Qemu-devel] Vhost-user - multi queue support

[Nikolay Nikolaev]

[-- Attachment #1: Type: text/plain, Size: 691 bytes --]

On Tue, Dec 2, 2014 at 1:42 PM, Long, Thomas <thomas.long@intel.com> wrote:

>  Hi All,
>
> I’m just wondering what the status is with regards to supporting
> multi-queue in Vhost-user?
>
>
>
> I see that Nikolaev has developed a patch to support this feature:
>
>
> https://github.com/SnabbCo/qemu/commit/f41eeccf4ab6ea5970e2941ce2de0aae893b10f9
>
>
>

This patch was developed by VirtualOpenSystems  for snabbswitch. We're
plannig to send the patch to
the qemu devel list by the end of this week.

regards,
Nikolay NIkolaev


>  Are there any current plans to pull either this patch or a different
> patch into QEMU ?
>
>
>
> Regards,
>
> Tommy
>
>
>

[-- Attachment #2: Type: text/html, Size: 2163 bytes --]