From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvmXL-0004NW-PC for qemu-devel@nongnu.org; Tue, 02 Dec 2014 07:26:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XvmXE-00079R-V0 for qemu-devel@nongnu.org; Tue, 02 Dec 2014 07:26:35 -0500 Received: from mail-wg0-x236.google.com ([2a00:1450:400c:c00::236]:61051) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XvmXE-00079G-No for qemu-devel@nongnu.org; Tue, 02 Dec 2014 07:26:28 -0500 Received: by mail-wg0-f54.google.com with SMTP id l2so16898707wgh.41 for ; Tue, 02 Dec 2014 04:26:28 -0800 (PST) Date: Tue, 2 Dec 2014 13:26:24 +0100 From: Vasilis Liaskovitis Message-ID: <20141202122624.GA2828@clowntown> References: <1416836239-19314-1-git-send-email-vliaskov@gmail.com> <1416839105.20462.33.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416839105.20462.33.camel@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH v2] qtest/bios-tables: Add DMAR unit test on intel_iommu for q35 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: jan.kiszka@web.de, knut.omang@oracle.com, qemu-devel@nongnu.org, mst@redhat.com On Mon, Nov 23, 2014 at 04:25:05PM +0200, Marcel Apfelbaum wrote: > On Mon, 2014-11-24 at 14:37 +0100, Vasilis Liaskovitis wrote: > > The test enables intel_iommu on q35, looks for and reads the DMAR table as well > > as its only DRHC structure (for now), checking the header and checksums. > > Hi Vaisilis, > I had a deeper look to your patch and the code already checks > header and checksum for DMAR, all you had to do is to add your latest chunk: > > @@ -779,7 +823,7 @@ static void test_acpi_tcg(void) > > > > memset(&data, 0, sizeof(data)); > > data.machine = MACHINE_Q35; > > - test_acpi_one("-machine q35,accel=tcg", &data); > > + test_acpi_one("-machine q35,accel=tcg,iommu=on", &data); > > free_test_data(&data); > > You can check that it is automatically done by test_dst_table function. > You can add there a print to convince yourself. > > However what is missing is a DMAR binary table to compare the content with an expected one. > You can create it by running: > tests/acpi-test-data/rebuild-expected-aml.sh > > Then add the newly created file to tests/acpi-test-data/q35/DMAR sorry for the delay. thanks, I missed this. I sent v3 simply with the addition of the DMAR aml file and just the "iommu=on" chunk, as you suggested. - Vasilis