* [Qemu-devel] [PATCH] iotests: Specify qcow2 format for qemu-io in 059
@ 2014-12-03 9:15 Max Reitz
2014-12-03 9:38 ` Fam Zheng
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Max Reitz @ 2014-12-03 9:15 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, Fam Zheng, Stefan Hajnoczi, Max Reitz
There are two instances of iotest 059 using qemu-io on a qcow2 image. As
of "qemu-iotests: Use qemu-io -f $IMGFMT" the iotests can no longer rely
on $QEMU_IO doing probing, therefore the qcow2 format has to be
specified explicitly here.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/059 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059
index 3c053c2..2ed1a7f 100755
--- a/tests/qemu-iotests/059
+++ b/tests/qemu-iotests/059
@@ -106,8 +106,8 @@ _img_info
echo
echo "=== Converting to streamOptimized from image with small cluster size==="
TEST_IMG="$TEST_IMG.qcow2" IMGFMT=qcow2 IMGOPTS="cluster_size=4096" _make_test_img 1G
-$QEMU_IO -c "write -P 0xa 0 512" "$TEST_IMG.qcow2" | _filter_qemu_io
-$QEMU_IO -c "write -P 0xb 10240 512" "$TEST_IMG.qcow2" | _filter_qemu_io
+$QEMU_IO -f qcow2 -c "write -P 0xa 0 512" "$TEST_IMG.qcow2" | _filter_qemu_io
+$QEMU_IO -f qcow2 -c "write -P 0xb 10240 512" "$TEST_IMG.qcow2" | _filter_qemu_io
$QEMU_IMG convert -f qcow2 -O vmdk -o subformat=streamOptimized "$TEST_IMG.qcow2" "$TEST_IMG" 2>&1
echo
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] iotests: Specify qcow2 format for qemu-io in 059
2014-12-03 9:15 [Qemu-devel] [PATCH] iotests: Specify qcow2 format for qemu-io in 059 Max Reitz
@ 2014-12-03 9:38 ` Fam Zheng
2014-12-03 9:40 ` Fam Zheng
2014-12-03 12:41 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2014-12-03 9:38 UTC (permalink / raw)
To: Max Reitz; +Cc: Kevin Wolf, qemu-devel, Stefan Hajnoczi
On Wed, 12/03 10:15, Max Reitz wrote:
> There are two instances of iotest 059 using qemu-io on a qcow2 image. As
> of "qemu-iotests: Use qemu-io -f $IMGFMT" the iotests can no longer rely
> on $QEMU_IO doing probing, therefore the qcow2 format has to be
> specified explicitly here.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/059 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059
> index 3c053c2..2ed1a7f 100755
> --- a/tests/qemu-iotests/059
> +++ b/tests/qemu-iotests/059
> @@ -106,8 +106,8 @@ _img_info
> echo
> echo "=== Converting to streamOptimized from image with small cluster size==="
> TEST_IMG="$TEST_IMG.qcow2" IMGFMT=qcow2 IMGOPTS="cluster_size=4096" _make_test_img 1G
> -$QEMU_IO -c "write -P 0xa 0 512" "$TEST_IMG.qcow2" | _filter_qemu_io
> -$QEMU_IO -c "write -P 0xb 10240 512" "$TEST_IMG.qcow2" | _filter_qemu_io
> +$QEMU_IO -f qcow2 -c "write -P 0xa 0 512" "$TEST_IMG.qcow2" | _filter_qemu_io
> +$QEMU_IO -f qcow2 -c "write -P 0xb 10240 512" "$TEST_IMG.qcow2" | _filter_qemu_io
> $QEMU_IMG convert -f qcow2 -O vmdk -o subformat=streamOptimized "$TEST_IMG.qcow2" "$TEST_IMG" 2>&1
>
> echo
> --
> 1.9.3
>
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] iotests: Specify qcow2 format for qemu-io in 059
2014-12-03 9:15 [Qemu-devel] [PATCH] iotests: Specify qcow2 format for qemu-io in 059 Max Reitz
2014-12-03 9:38 ` Fam Zheng
@ 2014-12-03 9:40 ` Fam Zheng
2014-12-03 12:41 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Fam Zheng @ 2014-12-03 9:40 UTC (permalink / raw)
To: Max Reitz; +Cc: Kevin Wolf, qemu-devel, Stefan Hajnoczi
On Wed, 12/03 10:15, Max Reitz wrote:
> There are two instances of iotest 059 using qemu-io on a qcow2 image. As
> of "qemu-iotests: Use qemu-io -f $IMGFMT" the iotests can no longer rely
> on $QEMU_IO doing probing, therefore the qcow2 format has to be
> specified explicitly here.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/059 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059
> index 3c053c2..2ed1a7f 100755
> --- a/tests/qemu-iotests/059
> +++ b/tests/qemu-iotests/059
> @@ -106,8 +106,8 @@ _img_info
> echo
> echo "=== Converting to streamOptimized from image with small cluster size==="
> TEST_IMG="$TEST_IMG.qcow2" IMGFMT=qcow2 IMGOPTS="cluster_size=4096" _make_test_img 1G
> -$QEMU_IO -c "write -P 0xa 0 512" "$TEST_IMG.qcow2" | _filter_qemu_io
> -$QEMU_IO -c "write -P 0xb 10240 512" "$TEST_IMG.qcow2" | _filter_qemu_io
> +$QEMU_IO -f qcow2 -c "write -P 0xa 0 512" "$TEST_IMG.qcow2" | _filter_qemu_io
> +$QEMU_IO -f qcow2 -c "write -P 0xb 10240 512" "$TEST_IMG.qcow2" | _filter_qemu_io
> $QEMU_IMG convert -f qcow2 -O vmdk -o subformat=streamOptimized "$TEST_IMG.qcow2" "$TEST_IMG" 2>&1
>
> echo
> --
> 1.9.3
>
Reviewed-by: Fam Zheng <famz@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] iotests: Specify qcow2 format for qemu-io in 059
2014-12-03 9:15 [Qemu-devel] [PATCH] iotests: Specify qcow2 format for qemu-io in 059 Max Reitz
2014-12-03 9:38 ` Fam Zheng
2014-12-03 9:40 ` Fam Zheng
@ 2014-12-03 12:41 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2014-12-03 12:41 UTC (permalink / raw)
To: Max Reitz; +Cc: Fam Zheng, qemu-devel, Stefan Hajnoczi
Am 03.12.2014 um 10:15 hat Max Reitz geschrieben:
> There are two instances of iotest 059 using qemu-io on a qcow2 image. As
> of "qemu-iotests: Use qemu-io -f $IMGFMT" the iotests can no longer rely
> on $QEMU_IO doing probing, therefore the qcow2 format has to be
> specified explicitly here.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Thanks, applied to block-next.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-03 12:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-03 9:15 [Qemu-devel] [PATCH] iotests: Specify qcow2 format for qemu-io in 059 Max Reitz
2014-12-03 9:38 ` Fam Zheng
2014-12-03 9:40 ` Fam Zheng
2014-12-03 12:41 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).