From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwBGV-0001Lh-9r for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:50:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwBGO-0005Ud-Tc for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:50:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45037) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwBGO-0005UL-Mf for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:50:44 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB3EohRV009158 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 3 Dec 2014 09:50:44 -0500 Date: Wed, 3 Dec 2014 15:50:41 +0100 From: Kevin Wolf Message-ID: <20141203145041.GF4404@noname.str.redhat.com> References: <1417610103-18234-1-git-send-email-kwolf@redhat.com> <87h9xckdek.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87h9xckdek.fsf@blackfin.pond.sub.org> Subject: Re: [Qemu-devel] [PATCH] ide: Check validity of logical block size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: jsnow@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Am 03.12.2014 um 15:37 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Our IDE emulation can't handle logical block sizes other than 512. Check > > for it. > > I guess this is in part due to the 512 literals sprinkled all over the > IDE code. Yes, this is one part. The other part is where the 512 literals are missing and sector numbers are passed on to the block layer. Kevin