From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwBIp-0004s5-Gp for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:53:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwBIi-0005yT-9D for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:53:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46446) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwBIi-0005yF-2o for qemu-devel@nongnu.org; Wed, 03 Dec 2014 09:53:08 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB3Er7PL031283 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 3 Dec 2014 09:53:07 -0500 Date: Wed, 3 Dec 2014 15:53:05 +0100 From: Kevin Wolf Message-ID: <20141203145305.GG4404@noname.str.redhat.com> References: <1417610103-18234-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417610103-18234-1-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH] ide: Check validity of logical block size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: jsnow@redhat.com, stefanha@redhat.com Am 03.12.2014 um 13:35 hat Kevin Wolf geschrieben: > Our IDE emulation can't handle logical block sizes other than 512. Check > for it. > > The original assumption was that other values would silently be ignored > (which is bad enough), but it's not quite true: The physical block size > is exposed in IDENTIFY DEVICE as a multiple of the logical block size. > Setting a logical block size therefore also corrupts the physical block > size (4096/4096 doesn't silently downgrade to 4096/512, but 512/512). > > Signed-off-by: Kevin Wolf Applied to block-next. Kevin