Re: [Qemu-devel] [PATCH for-2.3] configure: Replace which(1) with "has"

[Amos Kong <akong@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

On Thu, Dec 04, 2014 at 02:18:16PM +0800, Fam Zheng wrote:
> Using "has" is more slick because which(1) is not always there.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 47048f0..cae588c 100755
> --- a/configure
> +++ b/configure
> @@ -2727,7 +2727,7 @@ fi
>  if test "$modules" = yes; then
>      shacmd_probe="sha1sum sha1 shasum"
>      for c in $shacmd_probe; do
> -        if which $c >/dev/null 2>&1; then
> +        if has $c; then

we use self defined has function to check command in all other place
in configure. LGTM.

Reviewed-by: Amos Kong <akong@redhat.com>

>              shacmd="$c"
>              break
>          fi
> -- 
> 1.9.3
> 

-- 
			Amos.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]