From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34309)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <junmuzi@gmail.com>) id 1XxyiJ-0001ri-3b
	for qemu-devel@nongnu.org; Mon, 08 Dec 2014 08:51:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <junmuzi@gmail.com>) id 1XxyiA-0007A5-2A
	for qemu-devel@nongnu.org; Mon, 08 Dec 2014 08:50:59 -0500
Received: from mail-pd0-x22e.google.com ([2607:f8b0:400e:c02::22e]:41265)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <junmuzi@gmail.com>) id 1Xxyi9-00078w-Rp
	for qemu-devel@nongnu.org; Mon, 08 Dec 2014 08:50:50 -0500
Received: by mail-pd0-f174.google.com with SMTP id fp1so4851613pdb.5
	for <qemu-devel@nongnu.org>; Mon, 08 Dec 2014 05:50:47 -0800 (PST)
Date: Mon, 8 Dec 2014 21:50:39 +0800
From: Jun Li <junmuzi@gmail.com>
Message-ID: <20141208135039.GA2836@localhost.localdomain>
References: <20141205153210.GA4573@localhost.localdomain>
	<20141208100707.GB3792@noname.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20141208100707.GB3792@noname.str.redhat.com>
Subject: Re: [Qemu-devel] qcow2: Can create qcow2 image format on rbd server
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: josh.durgin@inktank.com, juli@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Mon, 12/08 11:07, Kevin Wolf wrote:
> Am 05.12.2014 um 16:32 hat Jun Li geschrieben:
> > Currently, qemu-img can not create qcow2 image format on rbd server. Analysis
> > the code as followings:
> > when create qcow2 format image:
> > qcow2_create2
> >   bdrv_create_file(filename, opts, &local_err);  --> Here will create a 0 size
> >   file(e.g: file1) on rbd server.
> >   ...
> >   ret = bdrv_pwrite(bs, 0, header, cluster_size); --> So here can not write
> >   qcow2 header into file1 due to the file1's length is 0. Seems
> >   qemu_rbd_aio_writev can not write beyond EOF.
> >   ...
> > 
> > As above analysis, there are two methods to solve the above bz as followings:
> > 1, When create file1, just create a fixed-size file1 on rbd server(not 0 size).
> 
> This is not a solution. Even if you might be able to create an image
> successfully, using qcow2 without a backend that allows the image file
> to grow is bound to fail sooner or later.
> 
> So yes, you'll want to extend the rbd block driver to grow the file
> asynchronously when writing beyond EOF.
> 

Hi Kevin,

  Although rbd_resize is synchronous, I just want to create a new child-thread
to realize asynchronous(Maybe just like userspace aio: libaio) rbd_resize.
Just like following:

qemu_rbd_aio_writev()
{
    if (BlockDriverState->file->growable == 1) {
        pthread_create(&thread_id, NULL, child_thread, NULL);
    }

    rbd_start_aio();
}

child_thread()
{
    ...
    rbd_resize();
    rbd_start_aio();
    ...
}

Currently, seems do not have original asynchronous rbd_resize. Besides, rbd block
driver do not support growable file. So I want to use above method to realize
asynchronous rbd_resize() in our qemu level.

What's your opinion?

Regards,
Jun Li