From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35598)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Xy3kZ-00065X-11
	for qemu-devel@nongnu.org; Mon, 08 Dec 2014 14:13:45 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Xy3kS-0003kp-SK
	for qemu-devel@nongnu.org; Mon, 08 Dec 2014 14:13:38 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37099)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1Xy3kS-0003kf-Kd
	for qemu-devel@nongnu.org; Mon, 08 Dec 2014 14:13:32 -0500
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB8JDVvu004191
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Mon, 8 Dec 2014 14:13:31 -0500
Date: Mon, 8 Dec 2014 21:13:25 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20141208191325.GB29469@redhat.com>
References: <1418054888-11310-1-git-send-email-imammedo@redhat.com>
	<1418054888-11310-3-git-send-email-imammedo@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1418054888-11310-3-git-send-email-imammedo@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/9] pc: acpi: decribe bridge device as not
	hotpluggable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, marcel.a@redhat.com

On Mon, Dec 08, 2014 at 04:08:01PM +0000, Igor Mammedov wrote:
> when bridge hotplug is disabled, i.e. for machine
> types less then 2.0, bridge device was created as
> hotpluggable by mistake since commit 133a2da.
> 
> Fix it by just creating it as a present device.
> 
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>

What exactly is the problem here?
It seems that such bridge is hotpluggable, even though
e.g. windows guests lacks drivers to support this.


> ---
>  hw/i386/acpi-build.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index b37a397..1fb92e5 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -913,7 +913,7 @@ static void build_pci_bus_end(PCIBus *bus, void *bus_state)
>              }
>          }
>  
> -        if (!dc->hotpluggable || bridge_in_acpi) {
> +        if (!dc->hotpluggable || pc->is_bridge) {
>              clear_bit(slot, slot_hotplug_enable);
>          }
>      }
> -- 
> 1.8.3.1