From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xy69y-00075h-Ap for qemu-devel@nongnu.org; Mon, 08 Dec 2014 16:48:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xy69t-00020I-Ac for qemu-devel@nongnu.org; Mon, 08 Dec 2014 16:48:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54414) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xy69t-0001zd-2R for qemu-devel@nongnu.org; Mon, 08 Dec 2014 16:47:57 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB8LlfEd003717 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 8 Dec 2014 16:47:56 -0500 Date: Mon, 8 Dec 2014 22:43:50 +0200 From: "Michael S. Tsirkin" Message-ID: <20141208204350.GE29909@redhat.com> References: <1418054888-11310-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418054888-11310-1-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/9] pc: acpi: various fixes and cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, marcel.a@redhat.com On Mon, Dec 08, 2014 at 04:07:59PM +0000, Igor Mammedov wrote: > this series is an early attempt to shave off a bunch of > not directly related patches from already big dynamic > AML series (although it's dependency for it) > > main target of this series is: > > pc: acpi-build: replace recursive PCI bus tree generation with loop > based > > A simplified PCI description generation, which replaces tree > structure with a set of ACPI scopes and allows later easily replace > template patching with direct AML generation with further > simplification. I considered this early on. Unfortunately using scopes almost doubles the ACPI size for deep hierarchies. I'm fine with flattening the generation code but I think we are better off keeping the AML hierarchical. More on the patch itself. > Tested: on XPsp3 to WS2012R2 and REHL6/7 guests. > > Git tree for testing: > https://github.com/imammedo/qemu/commits/acpi_pci_gen_simplification > > > Igor Mammedov (9): > pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled > pc: acpi: decribe bridge device as not hotpluggable > pc: acpi-build: cleanup AcpiPmInfo initialization > acpi: build_append_nameseg(): add padding if necessary > acpi: move generic aml building helpers into dedictated file > acpi: add build_append_namestring() helper > acpi: replace opencoded notify codes with named values > acpi: drop min-bytes in build_package() > pc: acpi-build: replace recursive PCI bus tree generation with loop > based > > hw/acpi/Makefile.objs | 1 + > hw/acpi/acpi_gen_utils.c | 247 +++++++++++++++++ > hw/i386/acpi-build.c | 561 +++++++++++++------------------------- > hw/i386/acpi-dsdt-cpu-hotplug.dsl | 1 + > include/hw/acpi/acpi_gen_utils.h | 29 ++ > 5 files changed, 462 insertions(+), 377 deletions(-) > create mode 100644 hw/acpi/acpi_gen_utils.c > create mode 100644 include/hw/acpi/acpi_gen_utils.h > > -- > 1.8.3.1