From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xy5Mo-00029o-NC for qemu-devel@nongnu.org; Mon, 08 Dec 2014 15:57:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xy5Mi-0000Tj-If for qemu-devel@nongnu.org; Mon, 08 Dec 2014 15:57:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xy5Mi-0000TR-BL for qemu-devel@nongnu.org; Mon, 08 Dec 2014 15:57:08 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB8Kv7Wo016924 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 8 Dec 2014 15:57:07 -0500 Date: Mon, 8 Dec 2014 22:57:05 +0200 From: "Michael S. Tsirkin" Message-ID: <20141208205705.GA30082@redhat.com> References: <1418054888-11310-1-git-send-email-imammedo@redhat.com> <1418054888-11310-2-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418054888-11310-2-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/9] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, marcel.a@redhat.com On Mon, Dec 08, 2014 at 04:08:00PM +0000, Igor Mammedov wrote: > ACPI parser in XP considers PNP0A06 devices of CPU and > memory hotplug as duplicates. Adding unique _UID > to CPU hotplug device fixes BSOD. > > Signed-off-by: Igor Mammedov And let's add them for memory hotplug as well? Also, if we do stable branch release, we probably want to only do it for memory hotplug in a separate patch, right? This way users who don't enable memory hotplug are unaffected, reduces risk slightly. > --- > hw/i386/acpi-dsdt-cpu-hotplug.dsl | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/i386/acpi-dsdt-cpu-hotplug.dsl b/hw/i386/acpi-dsdt-cpu-hotplug.dsl > index 34aab5a..268d870 100644 > --- a/hw/i386/acpi-dsdt-cpu-hotplug.dsl > +++ b/hw/i386/acpi-dsdt-cpu-hotplug.dsl > @@ -94,6 +94,7 @@ Scope(\_SB) { > > Device(CPU_HOTPLUG_RESOURCE_DEVICE) { > Name(_HID, EisaId("PNP0A06")) > + Name(_UID, "CPU hotplug resources") > > Name(_CRS, ResourceTemplate() { > IO(Decode16, CPU_STATUS_BASE, CPU_STATUS_BASE, 0, CPU_STATUS_LEN) > -- > 1.8.3.1