qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Kashyap Chamarthy <kchamart@redhat.com>
Subject: Re: [Qemu-devel] Cubietruck: cannot create KVM guests: "kvm_init_vcpu failed: Invalid argument"
Date: Tue, 9 Dec 2014 11:27:02 +0000	[thread overview]
Message-ID: <20141209112702.GA15695@redhat.com> (raw)
In-Reply-To: <CAFEAcA9Z-nR87UOEuuXV7cDr5zjptU7x1aEr=nFv926+XoEvhA@mail.gmail.com>

On Tue, Dec 09, 2014 at 10:53:41AM +0000, Peter Maydell wrote:
> On 9 December 2014 at 10:50, Kashyap Chamarthy <kchamart@redhat.com> wrote:
> > Booting a minimal KVM guest throws the below error on Cubietruck:
> >
> >   "kvm_init_vcpu failed: Invalid argument"
> >
> > More context and an easy reproducer in this QEMU bug[1] for Fedora.
> >
> > Context quoting Rich Jones from comment #2:
> >
> >     "For some reason I thought this had been fixed upstream, but
> >     now that I've finally got my CT working again, I see that I
> >     am still carrying that patch in my custom qemu.
> >
> >     diff --git a/target-arm/cpu.c b/target-arm/cpu.c
> >     index 5ce7350..04d69d1 100644
> >     --- a/target-arm/cpu.c
> >     +++ b/target-arm/cpu.c
> >     @@ -858,7 +858,7 @@ static void cortex_a15_initfn(Object *obj)
> >          set_feature(&cpu->env, ARM_FEATURE_DUMMY_C15_REGS);
> >          set_feature(&cpu->env, ARM_FEATURE_CBAR_RO);
> >          set_feature(&cpu->env, ARM_FEATURE_LPAE);
> >     -    cpu->kvm_target = QEMU_KVM_ARM_TARGET_CORTEX_A15;
> >     +    cpu->kvm_target = QEMU_KVM_ARM_TARGET_CORTEX_A7;
> >          cpu->midr = 0x412fc0f1;
> >          cpu->reset_fpsid = 0x410430f0;
> >          cpu->mvfr0 = 0x10110222;
> 
> This is obviously a bogus patch -- this is the initfn
> for Cortex-A15 so telling it to be a Cortex-A7 is wrong
> (and would break working setups on A15 hosts).

Yes, I definitely was not proposing this as a serious patch!  In my
copy of qemu it has "HACK" in all capital letters in the summary ...

> >     So that's the answer really, it's a qemu bug.  Actually it looks as
> >     if qemu contains some code to try to get the host CPU type, but it
> >     doesn't work, or maybe we need to pass a -cpu option ..."
> 
> Yes, you need to pass a -cpu option. For KVM on ARM, you
> always need to either:
>  * pass a -cpu option matching the host CPU
>  * pass "-cpu host"
> 
> The CubieTruck is a Cortex-A7, which we don't have specific
> support for in QEMU, so you will need "-cpu host".

Kashyap ^^ can you try this?  Should be a trivial one-liner change
in src/launch-direct.c.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html

  reply	other threads:[~2014-12-09 11:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 10:50 [Qemu-devel] Cubietruck: cannot create KVM guests: "kvm_init_vcpu failed: Invalid argument" Kashyap Chamarthy
2014-12-09 10:53 ` Peter Maydell
2014-12-09 11:27   ` Richard W.M. Jones [this message]
2014-12-09 12:15     ` Kashyap Chamarthy
2014-12-09 16:48     ` Kashyap Chamarthy
2014-12-09 11:25 ` Richard W.M. Jones
2014-12-09 11:42   ` Peter Maydell
2014-12-09 12:33     ` Dr. David Alan Gilbert
2014-12-09 13:48       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141209112702.GA15695@redhat.com \
    --to=rjones@redhat.com \
    --cc=kchamart@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).