From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41831)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XyI2z-0003OU-RH
	for qemu-devel@nongnu.org; Tue, 09 Dec 2014 05:29:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XyI2t-0002bz-MX
	for qemu-devel@nongnu.org; Tue, 09 Dec 2014 05:29:37 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35914)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1XyI2t-0002br-EV
	for qemu-devel@nongnu.org; Tue, 09 Dec 2014 05:29:31 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB9ATRLB016551
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Tue, 9 Dec 2014 05:29:30 -0500
Date: Tue, 9 Dec 2014 11:29:10 +0100
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20141209112910.772bb4e7@nial.usersys.redhat.com>
In-Reply-To: <20141208210302.GC30082@redhat.com>
References: <1418054888-11310-1-git-send-email-imammedo@redhat.com>
	<1418054888-11310-4-git-send-email-imammedo@redhat.com>
	<20141208210302.GC30082@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/9] pc: acpi-build: cleanup AcpiPmInfo
 initialization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, marcel.a@redhat.com

On Mon, 8 Dec 2014 23:03:02 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Mon, Dec 08, 2014 at 04:08:02PM +0000, Igor Mammedov wrote:
> > zero initialize AcpiPmInfo struct to reduce code bloat
> > a little bit.
> > 
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> 
> I generally prefer explicit initialization, but
> it's a matter of taste.
I did this since it saves some LOCs and will save even
more later with patches for dynamic _CRS.

> > ---
> >  hw/i386/acpi-build.c | 8 ++------
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> > 
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index 1fb92e5..f5ec66a 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -161,6 +161,8 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
> >      Object *obj = NULL;
> >      QObject *o;
> >  
> > +    memset(pm, 0, sizeof(*pm));
> > +
> >      if (piix) {
> >          obj = piix;
> >      }
> > @@ -173,22 +175,16 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
> >      o = object_property_get_qobject(obj, ACPI_PM_PROP_S3_DISABLED, NULL);
> >      if (o) {
> >          pm->s3_disabled = qint_get_int(qobject_to_qint(o));
> > -    } else {
> > -        pm->s3_disabled = false;
> >      }
> >      qobject_decref(o);
> >      o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_DISABLED, NULL);
> >      if (o) {
> >          pm->s4_disabled = qint_get_int(qobject_to_qint(o));
> > -    } else {
> > -        pm->s4_disabled = false;
> >      }
> >      qobject_decref(o);
> >      o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL);
> >      if (o) {
> >          pm->s4_val = qint_get_int(qobject_to_qint(o));
> > -    } else {
> > -        pm->s4_val = false;
> >      }
> >      qobject_decref(o);
> >  
> > -- 
> > 1.8.3.1
>