From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyKey-0000kS-RF for qemu-devel@nongnu.org; Tue, 09 Dec 2014 08:17:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyKes-0005Iq-Le for qemu-devel@nongnu.org; Tue, 09 Dec 2014 08:17:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46733) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyKes-0005Im-DT for qemu-devel@nongnu.org; Tue, 09 Dec 2014 08:16:54 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB9DGr0M010928 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 9 Dec 2014 08:16:53 -0500 Date: Tue, 9 Dec 2014 15:16:51 +0200 From: "Michael S. Tsirkin" Message-ID: <20141209131651.GA5116@redhat.com> References: <1418054888-11310-1-git-send-email-imammedo@redhat.com> <1418054888-11310-3-git-send-email-imammedo@redhat.com> <20141208191325.GB29469@redhat.com> <20141209112716.7bcca34e@nial.usersys.redhat.com> <20141209103402.GB3993@redhat.com> <20141209124527.0d433241@nial.usersys.redhat.com> <20141209125159.GA4674@redhat.com> <20141209135751.6d5fadc6@nial.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141209135751.6d5fadc6@nial.usersys.redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/9] pc: acpi: decribe bridge device as not hotpluggable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, marcel.a@redhat.com On Tue, Dec 09, 2014 at 01:57:51PM +0100, Igor Mammedov wrote: > On Tue, 9 Dec 2014 14:51:59 +0200 > "Michael S. Tsirkin" wrote: > > > On Tue, Dec 09, 2014 at 12:45:27PM +0100, Igor Mammedov wrote: > > > On Tue, 9 Dec 2014 12:34:02 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Tue, Dec 09, 2014 at 11:27:16AM +0100, Igor Mammedov wrote: > > > > > On Mon, 8 Dec 2014 21:13:25 +0200 > > > > > "Michael S. Tsirkin" wrote: > > > > > > > > > > > On Mon, Dec 08, 2014 at 04:08:01PM +0000, Igor Mammedov wrote: > > > > > > > when bridge hotplug is disabled, i.e. for machine > > > > > > > types less then 2.0, bridge device was created as > > > > > > > hotpluggable by mistake since commit 133a2da. > > > > > > > > > > > > > > Fix it by just creating it as a present device. > > > > > > > > > > > > > > Signed-off-by: Igor Mammedov > > > > > > > > > > > > What exactly is the problem here? > > > > > > It seems that such bridge is hotpluggable, even though > > > > > > e.g. windows guests lacks drivers to support this. > > > > > before 133a2da slot with existing at startup bridge weren't > > > > > marked as hotpluggable nor described in SSDT. But after > > > > > 133a2da it's described as hotpluggable slot for compat > > > > > machines (2.0 and lower) which doesn't match with original > > > > > behavior. > > > > > > > > > > Also Marcel mentioned that bridges could be hotpluggable > > > > > but that they should not be hot-UNpluggable. > > > > > > > > OK so is there some guest that's confused? > > > > What's the bug? > > > It allows to do eject on bridge when it shouldn't. > > > > I'm not sure it shouldn't. Assuming guest supports SHPC, eject on such a > > bridge might well work correctly. > If I remember correctly SHPC hotplug doesn't need ASL parts at all. Right. And then presumably bridge itself can be removed. > > > > > > > I don't know about consequences of it, > > > it's better not to allow invalid action in the first place. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > --- > > > > > > > hw/i386/acpi-build.c | 2 +- > > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > > > > > > > index b37a397..1fb92e5 100644 > > > > > > > --- a/hw/i386/acpi-build.c > > > > > > > +++ b/hw/i386/acpi-build.c > > > > > > > @@ -913,7 +913,7 @@ static void build_pci_bus_end(PCIBus *bus, void *bus_state) > > > > > > > } > > > > > > > } > > > > > > > > > > > > > > - if (!dc->hotpluggable || bridge_in_acpi) { > > > > > > > + if (!dc->hotpluggable || pc->is_bridge) { > > > > > > > clear_bit(slot, slot_hotplug_enable); > > > > > > > } > > > > > > > } > > > > > > > -- > > > > > > > 1.8.3.1