From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyNNU-0007Lz-F0 for qemu-devel@nongnu.org; Tue, 09 Dec 2014 11:11:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyNNL-0008A5-DN for qemu-devel@nongnu.org; Tue, 09 Dec 2014 11:11:08 -0500 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:42219) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyNNL-00089l-7K for qemu-devel@nongnu.org; Tue, 09 Dec 2014 11:10:59 -0500 Received: by mail-wg0-f45.google.com with SMTP id b13so1266004wgh.18 for ; Tue, 09 Dec 2014 08:10:58 -0800 (PST) Date: Tue, 9 Dec 2014 16:10:45 +0000 From: Stefan Hajnoczi Message-ID: <20141209161045.GE27053@stefanha-thinkpad.redhat.com> References: <1417465816-19345-1-git-send-email-jsnow@redhat.com> <1417465816-19345-4-git-send-email-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GxcwvYAGnODwn7V8" Content-Disposition: inline In-Reply-To: <1417465816-19345-4-git-send-email-jsnow@redhat.com> Subject: Re: [Qemu-devel] [PATCH v9 03/10] block: Introduce bdrv_dirty_bitmap_granularity() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: kwolf@redhat.com, Fam Zheng , armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, vsementsov@parallels.com, stefanha@redhat.com, pbonzini@redhat.com --GxcwvYAGnODwn7V8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 01, 2014 at 03:30:09PM -0500, John Snow wrote: > diff --git a/include/block/block.h b/include/block/block.h > index 066ded6..f180f93 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -440,6 +440,8 @@ void bdrv_dirty_bitmap_make_anon(BlockDriverState *bs, BdrvDirtyBitmap *bitmap); > void bdrv_release_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap); > BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs); > uint64_t bdrv_dbm_calc_def_granularity(BlockDriverState *bs); > +int64_t bdrv_dirty_bitmap_granularity(BlockDriverState *bs, > + BdrvDirtyBitmap *bitmap); This looks weird now. The default granularity has uint64_t type but the actual granularity has int64_t. Please make them consistent. --GxcwvYAGnODwn7V8 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUhx8FAAoJEJykq7OBq3PI7H0H/2OQ9V7AnZ9ywbyPvZk/5Kh8 iXJVUvfe8+rqg9qg2bIQrSQn3Nnt721hswf4npB8cKXyIQbNjRhXi+nqqEsaPrtU LfyQT/OMUeJzVhs3hByDiMEHBwO9SJL6eaWm56l8rTuQnSN5T+LH2ujSiuwBcbru GJ+AoikUcf3yA1a05t0TtYcTUIc9j5J1817mgwzpBjbbjIt6o2iXFPmVTf0OHeot ahYQ8mwqp7kgPMp2nUHfFouqkAlRg7GiyhmY3u+FSQPwfcmqxZjqMFBTqp5cXlWG aVWFC9qCwWGjT7/oXEXhHHDhLtD4THXWyQAN5GngoHupKHDQNQRG4f9DSnsklIM= =8VME -----END PGP SIGNATURE----- --GxcwvYAGnODwn7V8--