From: Stefan Hajnoczi <stefanha@gmail.com>
To: John Snow <jsnow@redhat.com>
Cc: kwolf@redhat.com, Fam Zheng <famz@redhat.com>,
armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com,
vsementsov@parallels.com, stefanha@redhat.com,
pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v9 04/10] hbitmap: Add hbitmap_copy
Date: Tue, 9 Dec 2014 17:19:16 +0000 [thread overview]
Message-ID: <20141209171916.GF27053@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1417465816-19345-5-git-send-email-jsnow@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
On Mon, Dec 01, 2014 at 03:30:10PM -0500, John Snow wrote:
> +HBitmap *hbitmap_copy(const HBitmap *bitmap)
> +{
> + int i;
> + uint64_t size;
> + HBitmap *hb = g_memdup(bitmap, sizeof(HBitmap));
> +
> + size = bitmap->size;
> + for (i = HBITMAP_LEVELS - 1; i >= 0; i--) {
> + size = MAX((size + BITS_PER_LONG - 1) >> BITS_PER_LEVEL, 1);
> + hb->levels[i] = g_memdup(bitmap->levels[i],
> + size * sizeof(unsigned long));
> + }
> +
> + return hb;
> +}
It would be handy to put a comment in struct HBitmap warning people that
hbitmap_copy() must be kept in sync when new pointer fields are added.
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2014-12-09 17:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 20:30 [Qemu-devel] [PATCH v9 00/10] block: Incremental backup series John Snow
2014-12-01 20:30 ` [Qemu-devel] [PATCH v9 01/10] qapi: Add optional field "name" to block dirty bitmap John Snow
2014-12-01 20:38 ` Eric Blake
2014-12-01 20:30 ` [Qemu-devel] [PATCH v9 02/10] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove John Snow
2014-12-01 21:42 ` Eric Blake
2014-12-09 16:00 ` Stefan Hajnoczi
2014-12-10 12:43 ` Markus Armbruster
2014-12-12 10:53 ` Stefan Hajnoczi
2014-12-15 8:50 ` Markus Armbruster
2014-12-17 12:07 ` John Snow
2014-12-17 16:12 ` Markus Armbruster
2014-12-01 20:30 ` [Qemu-devel] [PATCH v9 03/10] block: Introduce bdrv_dirty_bitmap_granularity() John Snow
2014-12-09 16:10 ` Stefan Hajnoczi
2014-12-01 20:30 ` [Qemu-devel] [PATCH v9 04/10] hbitmap: Add hbitmap_copy John Snow
2014-12-09 17:19 ` Stefan Hajnoczi [this message]
2014-12-01 20:30 ` [Qemu-devel] [PATCH v9 05/10] block: Add bdrv_copy_dirty_bitmap and bdrv_reset_dirty_bitmap John Snow
2014-12-10 8:11 ` Vladimir Sementsov-Ogievskiy
2014-12-01 20:30 ` [Qemu-devel] [PATCH v9 06/10] qmp: Add block-dirty-bitmap-enable and block-dirty-bitmap-disable John Snow
2014-12-09 17:28 ` Stefan Hajnoczi
2014-12-01 20:30 ` [Qemu-devel] [PATCH v9 07/10] qmp: Add support of "dirty-bitmap" sync mode for drive-backup John Snow
2014-12-09 17:44 ` Stefan Hajnoczi
2014-12-10 1:34 ` Fam Zheng
2014-12-12 10:58 ` Stefan Hajnoczi
2014-12-01 20:30 ` [Qemu-devel] [PATCH v9 08/10] qapi: Add transaction support to block-dirty-bitmap-{add, enable, disable} John Snow
2014-12-09 17:45 ` Stefan Hajnoczi
2014-12-01 20:30 ` [Qemu-devel] [PATCH v9 09/10] qmp: Add dirty bitmap 'enabled' field in query-block John Snow
2014-12-01 20:30 ` [Qemu-devel] [PATCH v9 10/10] qemu-iotests: Add tests for drive-backup sync=dirty-bitmap John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141209171916.GF27053@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vsementsov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).