From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyiyE-0005KO-SO for qemu-devel@nongnu.org; Wed, 10 Dec 2014 10:14:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xyiy5-0001Nr-Qc for qemu-devel@nongnu.org; Wed, 10 Dec 2014 10:14:30 -0500 Received: from mail-wg0-x235.google.com ([2a00:1450:400c:c00::235]:39134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xyiy5-0001Nk-IK for qemu-devel@nongnu.org; Wed, 10 Dec 2014 10:14:21 -0500 Received: by mail-wg0-f53.google.com with SMTP id l18so3912049wgh.12 for ; Wed, 10 Dec 2014 07:14:20 -0800 (PST) Date: Wed, 10 Dec 2014 15:14:18 +0000 From: Stefan Hajnoczi Message-ID: <20141210151418.GB30812@stefanha-thinkpad.redhat.com> References: <1417613866-25890-1-git-send-email-mreitz@redhat.com> <1417613866-25890-3-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4bRzO86E/ozDv8r1" Content-Disposition: inline In-Reply-To: <1417613866-25890-3-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 02/26] qcow2: Add refcount_bits to format-specific info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi --4bRzO86E/ozDv8r1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 03, 2014 at 02:37:22PM +0100, Max Reitz wrote: > Add the bit width of every refcount entry to the format-specific > information. >=20 > In contrast to lazy_refcounts and the corrupt flag, this should be > always emitted, even for compat=3D0.10 although it does not support any > refcount width other than 16 bits. This is because if a boolean is > optional, one normally assumes it to be false when omitted; but if an > integer is not specified, it is rather difficult to guess its value. >=20 > This new field breaks some test outputs, fix them. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2.c | 4 +++- > qapi/block-core.json | 5 ++++- > tests/qemu-iotests/060.out | 1 + > tests/qemu-iotests/065 | 23 +++++++++++++++-------- > tests/qemu-iotests/067.out | 5 +++++ > tests/qemu-iotests/082.out | 7 +++++++ > tests/qemu-iotests/089.out | 2 ++ > 7 files changed, 37 insertions(+), 10 deletions(-) Reviewed-by: Stefan Hajnoczi --4bRzO86E/ozDv8r1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUiGNKAAoJEJykq7OBq3PIiV4H/3m+dgG5y8gXTKnkdw4pzFlN dDVX5QfUIuhMlpQBr+8J2JZ1fy7VocSuQe6+DlUDsJ11fl2BwJBFiVMyFchAWncQ WwcuNvvS2EZ1jz3cjYZ3/tMHZZ8BW3UVYy+MjfNaL3lfKufoY3xVWAKUrJs/PKyp MdXUx6/o0C6x71XfY/jcDMD/28kQ7kQvoPW/tJMsHsW5AtTIkKI0jm0B3tUyAexV Tnpi0Y3npwrOBLeu5MVvm/2Ml/br8C9NgaM9znh0EHfQK2lucXBMIson/gshG5MT EDIrXP1ZTU35VF+ms6gV8WvMqbThXq5JMpvfJZMJy2eew69rlghSfPPiYthouIU= =7YV6 -----END PGP SIGNATURE----- --4bRzO86E/ozDv8r1--