From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xyizh-0006Th-Dy for qemu-devel@nongnu.org; Wed, 10 Dec 2014 10:16:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyizY-0002UG-4d for qemu-devel@nongnu.org; Wed, 10 Dec 2014 10:16:01 -0500 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:62762) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyizX-0002Tk-RG for qemu-devel@nongnu.org; Wed, 10 Dec 2014 10:15:51 -0500 Received: by mail-wi0-f176.google.com with SMTP id ex7so11530820wid.15 for ; Wed, 10 Dec 2014 07:15:51 -0800 (PST) Date: Wed, 10 Dec 2014 15:15:48 +0000 From: Stefan Hajnoczi Message-ID: <20141210151548.GC30812@stefanha-thinkpad.redhat.com> References: <1417613866-25890-1-git-send-email-mreitz@redhat.com> <1417613866-25890-4-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Qbvjkv9qwOGw/5Fx" Content-Disposition: inline In-Reply-To: <1417613866-25890-4-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 03/26] qcow2: Do not return new value after refcount update List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi --Qbvjkv9qwOGw/5Fx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 03, 2014 at 02:37:23PM +0100, Max Reitz wrote: > qcow2_update_cluster_refcount() does not have any quick access to the > new refcount value, it has to call qcow2_get_refcount(). Some callers do > not need that new value at all, others call qcow2_get_refcount() > themselves anyway (albeit in a different code path, which can however be > easily changed), therefore there is no advantage in making > qcow2_update_cluster_refcount() return the new value. Drop it. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 25 +++++++++++++++---------- > 1 file changed, 15 insertions(+), 10 deletions(-) Reviewed-by: Stefan Hajnoczi --Qbvjkv9qwOGw/5Fx Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUiGOkAAoJEJykq7OBq3PIxuEH/1rNDtHXXj/x0Xlr8XGGmt6A cEg6CXw/+ddrg82Ze8s47H93bHg88ECjYzmx0C5lH06W8PtRfnfdX6tQzAY5s5Mk Uhi/h1rQHIGfJvqB92aBjcbdYXIkysIhVKgZ+MKG5KE3NpMKjfoTKkyZ5+/2mvNb ImNLftlmCwmntFn/GSWgNfWtzNzY6RU6o2vxooKKJTBZ3qJ5S2fA7fScI98uS+ZZ 1jipkTvs1TBrYaF+nTsAzc6ygToaOE/Z+bYZC1P087+nsrOtIJ6WKMGAM3FmDbLo oSuCoxuMdgTQOXZ+JR0qdER6lGr9rtgkghfkI8hbbeUTEicFr8tNJesAFpvFnYY= =sdTZ -----END PGP SIGNATURE----- --Qbvjkv9qwOGw/5Fx--