From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XylCx-0004Os-F6 for qemu-devel@nongnu.org; Wed, 10 Dec 2014 12:38:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XylCo-00085Z-8C for qemu-devel@nongnu.org; Wed, 10 Dec 2014 12:37:51 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:60143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XylCn-00085T-Ut for qemu-devel@nongnu.org; Wed, 10 Dec 2014 12:37:42 -0500 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 10 Dec 2014 17:37:41 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 283BC2190045 for ; Wed, 10 Dec 2014 17:37:10 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sBAHbd4s53674000 for ; Wed, 10 Dec 2014 17:37:39 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sBAHbSV7018523 for ; Wed, 10 Dec 2014 10:37:36 -0700 Date: Wed, 10 Dec 2014 18:37:19 +0100 From: Cornelia Huck Message-ID: <20141210183719.6aefbcac.cornelia.huck@de.ibm.com> In-Reply-To: <1417525227-14051-19-git-send-email-cornelia.huck@de.ibm.com> References: <1417525227-14051-1-git-send-email-cornelia.huck@de.ibm.com> <1417525227-14051-19-git-send-email-cornelia.huck@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v5 18/19] virtio: support revision-specific features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: thuth@linux.vnet.ibm.com, kvm@vger.kernel.org, mst@redhat.com, rusty@rustcorp.com.au, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org On Tue, 2 Dec 2014 14:00:26 +0100 Cornelia Huck wrote: > Devices may support different sets of feature bits depending on which > revision they're operating at. Let's give the transport a way to > re-query the device about its features when the revision has been > changed. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/virtio-ccw.c | 12 ++++++++++-- > hw/virtio/virtio-bus.c | 14 ++++++++++++-- > include/hw/virtio/virtio-bus.h | 3 +++ > include/hw/virtio/virtio.h | 3 +++ > 4 files changed, 28 insertions(+), 4 deletions(-) There seems to be something wrong with this patch - I noticed when I fixed prop_bit64. Needs debugging.