From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35834)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XyrVN-0003Hl-5O
	for qemu-devel@nongnu.org; Wed, 10 Dec 2014 19:21:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XyrVH-0001ey-Hv
	for qemu-devel@nongnu.org; Wed, 10 Dec 2014 19:21:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43898)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1XyrVH-0001eq-AB
	for qemu-devel@nongnu.org; Wed, 10 Dec 2014 19:21:11 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBB0LAks022772
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 10 Dec 2014 19:21:10 -0500
Date: Thu, 11 Dec 2014 08:21:07 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20141211002107.GB3110@ad.nay.redhat.com>
References: <1418110684-19528-1-git-send-email-famz@redhat.com>
	<87oarbsm77.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87oarbsm77.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH for-2.3 0/2] block: Fix for trailing
 whitespace in qemu-img create and its tests
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>

On Wed, 12/10 13:50, Markus Armbruster wrote:
> Fam Zheng <famz@redhat.com> writes:
> 
> > This will make it easier to keep checkpatch.pl happy.
> >
> > Fam Zheng (2):
> >   qemu-iotests: Remove traling whitespaces in *.out
> >   block: Don't add trailing space in "Formating..." message
> 
> Sounds like PATCH 1 breaks the test, and PATCH 2 unbreaks it.  If that's
> the case, they need to be squashed.

No. Our qemu-iotests driver ignores ending space:

    if diff -w "$reference" $tmp.out >/dev/null 2>&1
    then
        echo ""
        if $err
        then
            :
        else
            echo "$seq `expr $stop - $start`" >>$tmp.time
        fi
    else
        echo " - output mismatch (see $seq.out.bad)"
        mv $tmp.out $seq.out.bad
        $diff -w "$reference" $seq.out.bad
        err=true
    fi

Are you happy with the "sep" or do you want a full-fledged version?

Fam