From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz1gN-0003eR-VF for qemu-devel@nongnu.org; Thu, 11 Dec 2014 06:13:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xz1g7-0007tn-OJ for qemu-devel@nongnu.org; Thu, 11 Dec 2014 06:13:19 -0500 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:48247) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz1g7-0007tj-I4 for qemu-devel@nongnu.org; Thu, 11 Dec 2014 06:13:03 -0500 Received: by mail-wg0-f42.google.com with SMTP id z12so6160384wgg.15 for ; Thu, 11 Dec 2014 03:13:03 -0800 (PST) Date: Thu, 11 Dec 2014 11:12:59 +0000 From: Stefan Hajnoczi Message-ID: <20141211111259.GH30812@stefanha-thinkpad.redhat.com> References: <1417613866-25890-1-git-send-email-mreitz@redhat.com> <1417613866-25890-9-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Enx9fNJ0XV5HaWRu" Content-Disposition: inline In-Reply-To: <1417613866-25890-9-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 08/26] qcow2: Refcount overflow and qcow2_alloc_bytes() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi --Enx9fNJ0XV5HaWRu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 03, 2014 at 02:37:28PM +0100, Max Reitz wrote: > qcow2_alloc_bytes() may reuse a cluster multiple times, in which case > the refcount is increased accordingly. However, if this would lead to an > overflow the function should instead just not reuse this cluster and > allocate a new one. >=20 > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 31 ++++++++++++++++++++++++++++++- > 1 file changed, 30 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi --Enx9fNJ0XV5HaWRu Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUiXw7AAoJEJykq7OBq3PIPIkH/05e7Nx7RvuH7qg5hIzL7xKQ 8whR+h+1o9YSdOQyEswVkvdTiowgrMLB20YV9akORAEecEQdnQxY2mDUAKZb1eqE vrSamx9J/Po7gGXypfobojcn6eezJgMJdawlmvv7Ar0P+wraey0vXRNHcE+B/w7v 1pBSB+b28xc6bun+R0H9q1IlDjElx7oeY9z+e6zPpBTowQajf6a8jpqzdShuc9is BLQmazL+AQGEWReRt+72vVSO9MFB5Nlqy/n0zgGCi4+JCPiuNzxtpupQitIzqkne 8RPiVMuzJQNfNCAOEVlSI/d6igYxhu/ecVZWLdhYin306t7RQCprygNWOM/B0+w= =skhl -----END PGP SIGNATURE----- --Enx9fNJ0XV5HaWRu--