From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz2DI-0000Vx-BY for qemu-devel@nongnu.org; Thu, 11 Dec 2014 06:47:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xz2DE-0003m4-I0 for qemu-devel@nongnu.org; Thu, 11 Dec 2014 06:47:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz2DE-0003lu-A4 for qemu-devel@nongnu.org; Thu, 11 Dec 2014 06:47:16 -0500 Date: Thu, 11 Dec 2014 11:47:10 +0000 From: "Daniel P. Berrange" Message-ID: <20141211114710.GE23831@redhat.com> References: <1418204253-5869-1-git-send-email-kraxel@redhat.com> <1418204253-5869-10-git-send-email-kraxel@redhat.com> <54887A35.3070801@redhat.com> <20141211094046.GA23831@redhat.com> <1418297615.1664.36.camel@nilsson.home.kraxel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1418297615.1664.36.camel@nilsson.home.kraxel.org> Subject: Re: [Qemu-devel] [PATCH v2 09/10] monitor: add query-vnc2 command Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Luiz Capitulino , qemu-devel@nongnu.org, Anthony Liguori , Markus Armbruster On Thu, Dec 11, 2014 at 12:33:35PM +0100, Gerd Hoffmann wrote: > Hi, > > > That's not a correct interpretation of the auth values - tls and x509 are > > not separate auth codes. VNC has one set of primary auth codes really > > > > none, vnc, vencrypt > > Well, the source code also has (see vnc_auth_name in ui/vnc.c): > > ra2, ra2ne, tight, ultra, tls, sasl True, though most of those aren't actually implemented (only SASL is) > > If using the vencrypt option there are a number of sub-auth codes > > > > tls-none, tls-vnc, tls-plain, tls-sasl x509-none, x509-vnc, x509-plain, x509-sasl > > So better add a 'vencrypt-subauth' enum with this list? Yeah probably a good idea Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|