From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz40H-00053N-AZ for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:42:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xz408-0006Gc-9Y for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:42:01 -0500 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:57337) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz408-0006GH-1J for qemu-devel@nongnu.org; Thu, 11 Dec 2014 08:41:52 -0500 Received: by mail-wi0-f178.google.com with SMTP id em10so8634026wid.17 for ; Thu, 11 Dec 2014 05:41:51 -0800 (PST) Date: Thu, 11 Dec 2014 13:41:47 +0000 From: Stefan Hajnoczi Message-ID: <20141211134147.GL30812@stefanha-thinkpad.redhat.com> References: <1417613866-25890-1-git-send-email-mreitz@redhat.com> <1417613866-25890-14-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="FxavXfDenm+F7xE/" Content-Disposition: inline In-Reply-To: <1417613866-25890-14-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 13/26] qcow2: refcount_order parameter for qcow2_create2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi --FxavXfDenm+F7xE/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 03, 2014 at 02:37:33PM +0100, Max Reitz wrote: > Add a refcount_order parameter to qcow2_create2(), use that value for > the image header and for calculating the size required for > preallocation. >=20 > For now, always pass 4. >=20 > This addition requires changes to the calculation of the file size for > the "full" and "falloc" preallocation modes. That in turn is a nice > opportunity to add a comment about that calculation not necessarily > being exact (and that being intentional). >=20 > Signed-off-by: Max Reitz > --- > block/qcow2.c | 46 +++++++++++++++++++++++++++++++++++----------- > 1 file changed, 35 insertions(+), 11 deletions(-) Reviewed-by: Stefan Hajnoczi --FxavXfDenm+F7xE/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUiZ8bAAoJEJykq7OBq3PISZQH/2u5rvW/6TvVFi3k8M8HAdlT Ub0l69l7kzM0WIebmfN0C+HVIqUyxQsgEfIgaqrwK+qrRqFNQP70SCOF7v3cERPu /hcIoVRO05G70JDQFIx3mIl1fI6hpITcB9mMJwm3empezY1pKYF1AtGAd+tNPehd xfLlkuIVVq5KWta2QoL38hxCm7nESPi7nBb3zc4OW9ClsNADPg0LMZYDbyoOclxv hClKF0UxPIMkBta0kt+q5fdhHbT8ar5wCL5XHjiO1OHVd8sQTihL9a5V/DhTIXO/ Zp+ObzxRAtTgGHZY856ONQVI3bQR9+X3ltX/uliMUIhaJkJ4T3XVyz35jgNhH94= =cYZZ -----END PGP SIGNATURE----- --FxavXfDenm+F7xE/--