From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50794)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Xz4NL-0002Xr-Mu
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 09:06:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Xz4NC-0006D6-MF
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 09:05:51 -0500
Received: from mail-wg0-x233.google.com ([2a00:1450:400c:c00::233]:65182)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Xz4NC-0006D2-F4
	for qemu-devel@nongnu.org; Thu, 11 Dec 2014 09:05:42 -0500
Received: by mail-wg0-f51.google.com with SMTP id x12so6508644wgg.10
	for <qemu-devel@nongnu.org>; Thu, 11 Dec 2014 06:05:41 -0800 (PST)
Date: Thu, 11 Dec 2014 14:05:39 +0000
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20141211140539.GM30812@stefanha-thinkpad.redhat.com>
References: <1417613866-25890-1-git-send-email-mreitz@redhat.com>
	<1417613866-25890-15-git-send-email-mreitz@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="0+35XlDF45POFHfm"
Content-Disposition: inline
In-Reply-To: <1417613866-25890-15-git-send-email-mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 14/26] qcow2: Use symbolic macros in
 qcow2_amend_options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>


--0+35XlDF45POFHfm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 03, 2014 at 02:37:34PM +0100, Max Reitz wrote:
> qcow2_amend_options() should not compare options against some inline
> strings but rather use the symbolic macros available for each of the
> creation options.
>=20
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  block/qcow2.c | 31 ++++++++++++++++---------------
>  1 file changed, 16 insertions(+), 15 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

--0+35XlDF45POFHfm
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUiaSzAAoJEJykq7OBq3PIiBYH/i+aGuUNNPOSwCHpxf7QMRm2
S9YhEOC4s9JJpqF1Gzsf7rKN6KubTrzGN3jfqoDA+UFjOMoDhMVd7vqwQ18n/ea7
cnhqDCZW2E/ywvBMkoUvgihqx89F4hHlCgu48qOVV24NEWuJKRS3ZYU0CBeDmLIr
rJZwTNW0qIIUUnkH7zv1QkbkZ7SD5CEO7EOeYkPiM4hWImo/GpPRoW/e2Z9ohcOn
vrDQcs8zTepeqfz23T7oRlq9+7bFBmG/Imuqx9/o4DYfyhwRDtdKmpi8S8kfT+Bi
hR6pAzAdY3l80fuizugWR1g/JkElmKj7wQ5Q3vZn8Xwp+Mqvxp8kmeCLRnrTEoc=
=jsol
-----END PGP SIGNATURE-----

--0+35XlDF45POFHfm--