From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34861) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz50t-0003Mk-ED for qemu-devel@nongnu.org; Thu, 11 Dec 2014 09:46:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xz50k-000441-E7 for qemu-devel@nongnu.org; Thu, 11 Dec 2014 09:46:43 -0500 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:61764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xz50k-00043o-7R for qemu-devel@nongnu.org; Thu, 11 Dec 2014 09:46:34 -0500 Received: by mail-wi0-f182.google.com with SMTP id h11so8875262wiw.9 for ; Thu, 11 Dec 2014 06:46:33 -0800 (PST) Date: Thu, 11 Dec 2014 14:46:31 +0000 From: Stefan Hajnoczi Message-ID: <20141211144631.GT30812@stefanha-thinkpad.redhat.com> References: <1417613866-25890-1-git-send-email-mreitz@redhat.com> <1417613866-25890-26-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="skzcsJvRJWOW8YcK" Content-Disposition: inline In-Reply-To: <1417613866-25890-26-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 25/26] qcow2: Point to amend function in check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi --skzcsJvRJWOW8YcK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 03, 2014 at 02:37:45PM +0100, Max Reitz wrote: > If a reference count is not representable with the current refcount > order, the image check should point to qemu-img amend for increasing the > refcount order. However, qemu-img amend needs write access to the image > which cannot be provided if the image is marked corrupt; and the image > check will not mark the image consistent unless everything actually is > consistent. >=20 > Therefore, if an image is marked corrupt and the image check encounters > a reference count overflow, it cannot be fixed by using qemu-img amend > to increase the refcount order. Instead, one has to use qemu-img convert > to create a completely new copy of the image in this case. >=20 > Alternatively, we may want to give the user a way of manually removing > the corrupt flag, maybe through qemu-img amend, but this is not part of > this patch. >=20 > Signed-off-by: Max Reitz > Reviewed-by: Eric Blake > --- > block/qcow2-refcount.c | 3 +++ > 1 file changed, 3 insertions(+) Reviewed-by: Stefan Hajnoczi --skzcsJvRJWOW8YcK Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUia5HAAoJEJykq7OBq3PIm2YH+wQbevOSXfzK0di/M43Zd1jv GQE6kkSoIw1ckZPzs3oTMbhY9+XlTHxN+BbVREBG6N/Bqqq7L1FMqZML90v8oBjo ouoxrPChNnGWp7OCOZB7VcXQQbkKn1bg08hur7bc8Xvd4Jc2lLOPfWDPR/KpcmY7 tX6laZA2nchxrV8X/0/eIKybAZa2YAp2GaHQFCDxrISpsR8uDQiPx28165gyoTBf F25+Mv3fju2jLG3UwsJdjNmuP2e8PnBR/XuCSrkP8lbESKKhadm42de/Va1FyRJ/ R2f07dE8iWOilhNX9vqStuLDAtLa4iuUOHyy9gzDg84tbrz9WdGGzkMsQ3sasN8= =oxEp -----END PGP SIGNATURE----- --skzcsJvRJWOW8YcK--