From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzMIZ-0008Ey-7A for qemu-devel@nongnu.org; Fri, 12 Dec 2014 04:14:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzMIO-0000LL-Qx for qemu-devel@nongnu.org; Fri, 12 Dec 2014 04:14:07 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:46562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzMIO-0000LC-GW for qemu-devel@nongnu.org; Fri, 12 Dec 2014 04:13:56 -0500 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 12 Dec 2014 09:13:55 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id AAF1717D8056 for ; Fri, 12 Dec 2014 09:14:15 +0000 (GMT) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sBC9DqP761210648 for ; Fri, 12 Dec 2014 09:13:52 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sBC9Dqwf009990 for ; Fri, 12 Dec 2014 02:13:52 -0700 Date: Fri, 12 Dec 2014 10:13:50 +0100 From: Cornelia Huck Message-ID: <20141212101350.609917a3.cornelia.huck@de.ibm.com> In-Reply-To: <20141212090821.GA8105@redhat.com> References: <1418374906-16358-1-git-send-email-cornelia.huck@de.ibm.com> <1418374906-16358-2-git-send-email-cornelia.huck@de.ibm.com> <20141212090821.GA8105@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] virtio: fix feature bit checks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Thomas Huth , qemu-devel@nongnu.org On Fri, 12 Dec 2014 11:08:21 +0200 "Michael S. Tsirkin" wrote: > On Fri, Dec 12, 2014 at 10:01:46AM +0100, Cornelia Huck wrote: > > Several places check against the feature bit number instead of against > > the feature bit. Fix them. > > > > Reported-by: Thomas Huth > > Signed-off-by: Cornelia Huck > > Cc: stable? Hm, yeah. Can you add it? > > > --- > > hw/scsi/virtio-scsi.c | 2 +- > > hw/virtio/dataplane/vring.c | 4 ++-- > > 2 files changed, 3 insertions(+), 3 deletions(-)