From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzQH7-00047b-2Y for qemu-devel@nongnu.org; Fri, 12 Dec 2014 08:29:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzQGy-00015X-1A for qemu-devel@nongnu.org; Fri, 12 Dec 2014 08:28:53 -0500 Received: from mail-wg0-x235.google.com ([2a00:1450:400c:c00::235]:48408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzQGx-00015M-Qv for qemu-devel@nongnu.org; Fri, 12 Dec 2014 08:28:43 -0500 Received: by mail-wg0-f53.google.com with SMTP id l18so9058188wgh.40 for ; Fri, 12 Dec 2014 05:28:43 -0800 (PST) Date: Fri, 12 Dec 2014 13:28:40 +0000 From: Stefan Hajnoczi Message-ID: <20141212132840.GC8409@stefanha-thinkpad.redhat.com> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZwgA9U+XZDXt4+m+" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 1/4] block: vhdx - remove redundant comments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, amulya.lokesha@emc.com, qemu-devel@nongnu.org, stefanha@redhat.com, mreitz@redhat.com --ZwgA9U+XZDXt4+m+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 08, 2014 at 01:07:42AM -0500, Jeff Cody wrote: > Minor cleanup. >=20 > Signed-off-by: Jeff Cody > --- > block/vhdx.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/block/vhdx.c b/block/vhdx.c > index 12bfe75..f1e1e2e 100644 > --- a/block/vhdx.c > +++ b/block/vhdx.c > @@ -1109,8 +1109,8 @@ static coroutine_fn int vhdx_co_readv(BlockDriverSt= ate *bs, int64_t sector_num, > /* check the payload block state */ > switch (s->bat[sinfo.bat_idx] & VHDX_BAT_STATE_BIT_MASK) { > case PAYLOAD_BLOCK_NOT_PRESENT: /* fall through */ > - case PAYLOAD_BLOCK_UNDEFINED: /* fall through */ > - case PAYLOAD_BLOCK_UNMAPPED: /* fall through */ > + case PAYLOAD_BLOCK_UNDEFINED: > + case PAYLOAD_BLOCK_UNMAPPED: > case PAYLOAD_BLOCK_ZERO: > /* return zero */ > qemu_iovec_memset(&hd_qiov, 0, 0, sinfo.bytes_avail); > @@ -1280,8 +1280,8 @@ static coroutine_fn int vhdx_co_writev(BlockDriverS= tate *bs, int64_t sector_num, > =20 > /* fall through */ > case PAYLOAD_BLOCK_NOT_PRESENT: /* fall through */ > - case PAYLOAD_BLOCK_UNMAPPED: /* fall through */ > - case PAYLOAD_BLOCK_UNDEFINED: /* fall through */ > + case PAYLOAD_BLOCK_UNMAPPED: > + case PAYLOAD_BLOCK_UNDEFINED: > bat_prior_offset =3D sinfo.file_offset; > ret =3D vhdx_allocate_block(bs, s, &sinfo.file_offset); > if (ret < 0) { Fall through comments are used by some static checkers. Not sure if all checkers are smart enough to propagate the comment from adjacent case statements. I would have left the comments alone but am okay with merging this. Stefan --ZwgA9U+XZDXt4+m+ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUiu2IAAoJEJykq7OBq3PIP5MH/ArjQKO7KKFxvvnUIwbYwxdX vsCho3Zwrdt/Rc6sFKwGElRNFl0Yqy2mxvReqSFe/JHhQjRu+Gipy3wNv92DeXz0 ZmSEerAIZYk5zp8W4ExSR0D/ewyF2okF8lebA0J4eZvVQTVXFiIE/SlyTTCSvRca T6R3aQVCMxlXeq99rzxF2jpLaf0w3cqitgGbmq3zt9/LZK6H9yQM927VZaQeEEuQ 4Ap+HC/0kn6lDoxSxtnClJMJl+zXsEYXa1VTMz4MFQKvLVwYNb5uPw7yoKUGGAUt vzpQiuBV4MU3my8RCRZdfMCd3P1syXOqoLg+RRVcR8YHMoV3akMF/X4H+AyZ48c= =ADgl -----END PGP SIGNATURE----- --ZwgA9U+XZDXt4+m+--