From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzRyd-0007fG-E2 for qemu-devel@nongnu.org; Fri, 12 Dec 2014 10:18:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzRyX-0006Yo-AX for qemu-devel@nongnu.org; Fri, 12 Dec 2014 10:17:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzRyX-0006YV-3R for qemu-devel@nongnu.org; Fri, 12 Dec 2014 10:17:49 -0500 Date: Fri, 12 Dec 2014 10:17:42 -0500 From: Jeff Cody Message-ID: <20141212151742.GA15426@localhost.localdomain> References: <5e582703e36450b9ca939e2e5c9fa3930030f7fe.1418018421.git.jcody@redhat.com> <54856647.1020509@redhat.com> <54895E8B.40900@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] block: vhdx - set .bdrv_has_zero_init to bdrv_has_zero_init_1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Lokesha, Amulya" Cc: "kwolf@redhat.com" , "qemu-devel@nongnu.org" , "stefanha@redhat.com" , Max Reitz On Fri, Dec 12, 2014 at 09:43:16AM -0500, Lokesha, Amulya wrote: > Hi Max, >=20 > =A0 Please reply in-line, it makes it easier to follow technical discussions - thanks :) >=20 > We applied all the 5 patches from the mail chain I got since the las= t > week. Please find attached the patches used by us. >=20 > We were unable to apply the patch3 as it failed with the following e= rror >=20 > =A0 >=20 > # patch -p1 < patch3 >=20 > patching file block/vhdx.c >=20 > patch: **** malformed patch at line 17:=A0=A0=A0=A0=A0=A0=A0=A0=A0 e= rror_setg_errno(errp, > EINVAL, "Image size too large; max of 64TB"); @@ -1936,7 +1936,9 @@ = static > QemuOptsList vhdx_create_opts =3D { >=20 > It looks like however you saved the patch file, it was corrupted. Looking at your attached patch 3, it split line 9 across 2 lines. Your patch also has whitespace differences from the patch I sent. You also attached 5 patches - Why are you using patch 0? You should only be applying patches 1-4. This should not be causing any actual issues, however. Are you using git for your qemu version? If so, 'git am' is the preferred method of applying the patches - just save each of the patch emails (the whole email should be fine), and run 'git am' on each file. >=20 > =A0 >=20 > Hence, we manually added the patch3 changes and recompiled the qemu.= We > then used the patched qemu-img to convert =A0our vmdk image to dynam= ic VHDX > format. We found that the image created this time had a considerable > decrease in its size from 50GB to 12GB. >=20 Could you tell me the file size of the VMDK image you were converting? Is it roughly 12GB as well? > However, when we deployed it into our SCVMM 2012, the import of the = VHDX > image failed with a "syntax error" as below >=20 > =A0 >=20 > Information (10804) >=20 > Unable to import \\Test.com\Library\VHDs\Test-disk1.vhdx because of = a > syntax error in the file. >=20 > =A0 If you run qemu-img info on Test-disk1.vhdx, what does it say? >=20 > Please let us know if we missed anything. >=20 > =A0 >=20 > Thanks, >=20 > Amulya >=20 > =A0 > [...] Jeff