From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzTC8-0005YF-IY for qemu-devel@nongnu.org; Fri, 12 Dec 2014 11:36:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzTC2-0007cU-Pi for qemu-devel@nongnu.org; Fri, 12 Dec 2014 11:35:56 -0500 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:58172) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzTC2-0007cO-IY for qemu-devel@nongnu.org; Fri, 12 Dec 2014 11:35:50 -0500 Received: by mail-wg0-f42.google.com with SMTP id z12so9648455wgg.15 for ; Fri, 12 Dec 2014 08:35:49 -0800 (PST) Date: Fri, 12 Dec 2014 16:35:46 +0000 From: Stefan Hajnoczi Message-ID: <20141212163546.GA12762@stefanha-thinkpad.redhat.com> References: <1418032092-16813-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UlVJffcvxoiEqYs2" Content-Disposition: inline In-Reply-To: <1418032092-16813-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 0/3] iotests: Fix test 039 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , Fam Zheng , Michael =?iso-8859-1?Q?M=FCller?= , Markus Armbruster , qemu-devel@nongnu.org, Stefan Hajnoczi --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 08, 2014 at 10:48:09AM +0100, Max Reitz wrote: > Test 039 used to fail because qemu-io -c abort may generate core dumps > even with ulimit -c 0 (and the output then contains "(core dumped)"). > Fix this by adding a new qemu-io command "sigraise" which invokes > raise(). Using this command to raise SIGKILL for example does not result > in a core dump, but it still badly crashes qemu-io (as desired). >=20 > I am sending this series because we need all tests to work before adding > the check-block target to "make check" (which we will hopefully do > soon). >=20 >=20 > v3: > - Patch 1: > - s/allows to raise/allows raising/ [Eric] > - %s/Unix signal/signal/g [Markus] > - Use SIGTERM instead of SIGKILL in the example, and don't hardcode > its value [Markus] > - Patch 3: > - Fix commit message (should have been "sigraise 9" instead of > "abort -S 9", and now it's "sigraise $(kill -l KILL)") [Fam] > - As hinted above, use "sigraise $(kill -l KILL)" instead of > hardcoding the value 9 for SIGKILL [Markus] >=20 >=20 > git-backport-diff against v2: >=20 > Key: > [----] : patches are identical > [####] : number of functional differences between upstream/downstream pat= ch > [down] : patch is downstream-only > The flags [FC] indicate (F)unctional and (C)ontextual differences, respec= tively >=20 > 001/3:[0008] [FC] 'qemu-io: Add sigraise command' > 002/3:[----] [--] 'iotests: Filter for "Killed" in qemu-io output' > 003/3:[0012] [FC] 'iotests: Fix test 039' >=20 >=20 > Max Reitz (3): > qemu-io: Add sigraise command > iotests: Filter for "Killed" in qemu-io output > iotests: Fix test 039 >=20 > qemu-io-cmds.c | 46 ++++++++++++++++++++++++++++++++++= ++++++ > tests/qemu-iotests/039 | 18 +++++++++++----- > tests/qemu-iotests/039.out | 6 +++--- > tests/qemu-iotests/common.filter | 2 +- > 4 files changed, 63 insertions(+), 9 deletions(-) >=20 > --=20 > 1.9.3 >=20 >=20 Thanks, applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan --UlVJffcvxoiEqYs2 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUixliAAoJEJykq7OBq3PIuUsH/1N8Kagy8l4j3ZxiQapXKhFR 445AGqthrlElkyCDjSARZtDdYZvKkMESKGmbvuJFyiY/Qx7UkgzO4oOqrclKI2a9 N5FtHg9iXinqk+zVajHBwSSvkcuPR/SOydDclT3I5qomToygfXFkgtv2CPVQOFv4 LhjKd+ECqHopOqc2ejUcTC/s/71W2lZKAGfGN/kA1YjDCtgfEbW23jucSt32nVCD eb8AP91FYKEVE4gWJzNSvGDs1gbcfA5Kqfq03kXmgtueMrnjVrGXZbkFclNsQXGp BNuq3QFspxnmrKtGr+CwXSbCbwshRUpjj8vve5b0ClEKuxe8EPX68BFP6IuSXfc= =+Sx4 -----END PGP SIGNATURE----- --UlVJffcvxoiEqYs2--