From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzTgd-0004DH-KG for qemu-devel@nongnu.org; Fri, 12 Dec 2014 12:07:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzTgY-0002xg-79 for qemu-devel@nongnu.org; Fri, 12 Dec 2014 12:07:27 -0500 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:47625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzTgY-0002xc-0u for qemu-devel@nongnu.org; Fri, 12 Dec 2014 12:07:22 -0500 Received: by mail-wg0-f45.google.com with SMTP id b13so9616123wgh.32 for ; Fri, 12 Dec 2014 09:07:21 -0800 (PST) Date: Fri, 12 Dec 2014 17:07:17 +0000 From: Stefan Hajnoczi Message-ID: <20141212170717.GD12762@stefanha-thinkpad.redhat.com> References: <1418305950-30924-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hoZxPH4CaxYzWscb" Content-Disposition: inline In-Reply-To: <1418305950-30924-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/5] linux-aio: rewrite and simplify queuing code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, ming.lei@canonical.com, pl@kamp.de, qemu-devel@nongnu.org, stefanha@redhat.com --hoZxPH4CaxYzWscb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Dec 11, 2014 at 02:52:25PM +0100, Paolo Bonzini wrote: > This series rewrites the io_submit code to avoid having to > synchronize the iocbs in two places (qemu_laiocb and LaioQueue). > Instead, the queue of pending I/O requests is kept in a list. >=20 > This fixes the problems with io_submit doing partial submissions > or failing with EAGAIN, without complicating the code. The bug is > shown by "qemu-img bench -n -t none -s 65536 -d 1024 -c 100000" > pretty much instantly. >=20 > Paolo >=20 > v1->v2: add patch 4, and fix QSIMPLEQ_SPLIT_AFTER >=20 > Paolo Bonzini (5): > linux-aio: queue requests that cannot be submitted > linux-aio: track whether the queue is blocked > linux-aio: rename LaioQueue idx field to "n" > linux-aio: drop return code from laio_io_unplug and ioq_submit > linux-aio: simplify removal of completed iocbs from the list >=20 > block/linux-aio.c | 99 ++++++++++++++++++++++++----------------------= ------ > block/raw-aio.h | 2 +- > include/qemu/queue.h | 11 ++++++ > 3 files changed, 58 insertions(+), 54 deletions(-) >=20 > --=20 > 2.1.0 >=20 >=20 Thanks, applied to my block-next tree: https://github.com/stefanha/qemu/commits/block-next Stefan --hoZxPH4CaxYzWscb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUiyDFAAoJEJykq7OBq3PIEUcH/iW9lsKqq5GQDcq1t8+PqV4W /M0X1qRCKIjMXWQJvcRC4HlH8NXiPjX9Oc+HWTuO5sy9jWpzqTeydhigC3aK8VlS afleP6Mves1nYgVQtBlP+yDzGGv3Qegvcpe/R4hA5phEnfYoEjG1R3WHrrvz10YM FZbEXTaSZB0U5HF0jQTWmwPDdmeoG+AGXNHhbIik+IrL55saymJj512HoKolmnnv EFkLxeg8SqOXuJb7zzYQdMzv+PUKN5ZqDTvv5dsFvGdQtPSXCHS6jVhMsJvntark mT/vk6XuA4rZ6QJ4bxGI+ZVnp0q7GcWQ61adXprQL7wCxDKD6uaIlcEOQjOpp68= =KHe/ -----END PGP SIGNATURE----- --hoZxPH4CaxYzWscb--