From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43304)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1XzUpO-0005ca-DY
	for qemu-devel@nongnu.org; Fri, 12 Dec 2014 13:20:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1XzUpF-0002zS-Fq
	for qemu-devel@nongnu.org; Fri, 12 Dec 2014 13:20:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:57768)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1XzUpF-0002zC-8J
	for qemu-devel@nongnu.org; Fri, 12 Dec 2014 13:20:25 -0500
Date: Fri, 12 Dec 2014 16:20:16 -0200
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20141212182016.GO5002@thinpad.lan.raisama.net>
References: <1418239610-3997-1-git-send-email-ehabkost@redhat.com>
	<1418239610-3997-2-git-send-email-ehabkost@redhat.com>
	<CAFEAcA-7+AMnxr4c4AMC6W7xjLHWPpfMW5by7jRH8RJ_bcAw4Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAFEAcA-7+AMnxr4c4AMC6W7xjLHWPpfMW5by7jRH8RJ_bcAw4Q@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v3 1/7] Move target_words_bigendian()
 prototype to exec-all.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Igor Mammedov <imammedo@redhat.com>

On Wed, Dec 10, 2014 at 07:44:04PM +0000, Peter Maydell wrote:
> On 10 December 2014 at 19:26, Eduardo Habkost <ehabkost@redhat.com> wrote:
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >  exec.c                  | 1 -
> >  hw/virtio/virtio.c      | 1 -
> >  include/exec/exec-all.h | 2 ++
> >  3 files changed, 2 insertions(+), 2 deletions(-)
> 
> I thought this prototype was deliberately not in a generally
> included header file because it's really not something that
> should be needed by most code.  If we do want to move it into
> a header then we definitely don't want it in exec-all.h.

I have no idea what would be the best place for the prototype, then.
CCing the people who introduced the function, in case they have any
suggestion.

Anyway, I don't want to make this series depend on dealing with the
virtio default-endianness mess, so in the next version I will drop this
patch and simply put the prototype inside tests/x86-stub.c.

-- 
Eduardo