From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41490) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0XSG-0004D2-Sp for qemu-devel@nongnu.org; Mon, 15 Dec 2014 10:21:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0XSC-0006RD-PE for qemu-devel@nongnu.org; Mon, 15 Dec 2014 10:21:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33600) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0XSC-0006R9-G0 for qemu-devel@nongnu.org; Mon, 15 Dec 2014 10:20:56 -0500 Date: Mon, 15 Dec 2014 15:20:50 +0000 From: "Daniel P. Berrange" Message-ID: <20141215152050.GF11566@redhat.com> References: <1418217570-15517-1-git-send-email-marcel.a@redhat.com> <1418217570-15517-4-git-send-email-marcel.a@redhat.com> <548EFB32.6010402@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <548EFB32.6010402@suse.de> Subject: Re: [Qemu-devel] [PATCH 3/3] vl.c: add HMP help to machine Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: peter.maydell@linaro.org, greg.bellows@linaro.org, mst@redhat.com, qemu-devel@nongnu.org, Marcel Apfelbaum On Mon, Dec 15, 2014 at 04:16:02PM +0100, Alexander Graf wrote: > > > On 10.12.14 14:19, Marcel Apfelbaum wrote: > > The help is based on the actual machine properties > > exposing only the relevant options. > > > > Signed-off-by: Marcel Apfelbaum > > Can libvirt make use of this or would it need QMP based exposure? Libvirt *never* looks at any -help option anymore. We exclusively use the QMP query-XXXX commands to discover information about QEMU. So if its not already possible to query existance of these new machine properties via QMP, it'll need work. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|