From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0Xaa-0003BA-W9 for qemu-devel@nongnu.org; Mon, 15 Dec 2014 10:29:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0XaU-00019W-Rr for qemu-devel@nongnu.org; Mon, 15 Dec 2014 10:29:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0XaU-00019O-KA for qemu-devel@nongnu.org; Mon, 15 Dec 2014 10:29:30 -0500 Date: Mon, 15 Dec 2014 15:29:23 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20141215152922.GH5502@work-vm> References: <1418388243-1886-1-git-send-email-pbonzini@redhat.com> <1418388243-1886-3-git-send-email-pbonzini@redhat.com> <20141215114018.GC5502@work-vm> <548ECE05.3050009@redhat.com> <20141215152125.GG5502@work-vm> <548EFDA6.3020509@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <548EFDA6.3020509@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 2/4] serial: clean up THRE/TEMT handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: imammedo@redhat.com, andrey@xdel.ru, qemu-devel@nongnu.org, dslutz@verizon.com, batuzovk@ispras.ru * Paolo Bonzini (pbonzini@redhat.com) wrote: > > > On 15/12/2014 16:21, Dr. David Alan Gilbert wrote: > >> > > >> > - serial_xmit is called from outside only after resetting TEMT and THRE > >> > and pushing a character on the FIFO > > Are you sure about TEMT? My reading of serial_ioport_write is that if > > !FCR_FE then TEMT isn't cleared. > > This patch changes that. Oh yeh! Reviewed-by: Dr. David Alan Gilbert > > Paolo -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK