* [Qemu-devel] [Bug 1402802] [NEW] target-tricore/translate.c:3812: possible bad expression ?
@ 2014-12-15 19:31 dcb
2014-12-15 20:32 ` [Qemu-devel] [Bug 1402802] " Bastian Koppelmann
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: dcb @ 2014-12-15 19:31 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
>From a run of cppcheck, a static analysis checker, over the
source code of qemu trunk, dated 20141215, is the new error:
[qemu/target-tricore/translate.c:3812]: (style) Expression '(X & 0x3f)
== 0x6f' is always false.
Source code is
if (unlikely((op1 & 0x3f) == OPCM_32_BRN_JTT)) {
Suggest code rework.
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1402802
Title:
target-tricore/translate.c:3812: possible bad expression ?
Status in QEMU:
New
Bug description:
From a run of cppcheck, a static analysis checker, over the
source code of qemu trunk, dated 20141215, is the new error:
[qemu/target-tricore/translate.c:3812]: (style) Expression '(X & 0x3f)
== 0x6f' is always false.
Source code is
if (unlikely((op1 & 0x3f) == OPCM_32_BRN_JTT)) {
Suggest code rework.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1402802/+subscriptions
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [Bug 1402802] Re: target-tricore/translate.c:3812: possible bad expression ?
2014-12-15 19:31 [Qemu-devel] [Bug 1402802] [NEW] target-tricore/translate.c:3812: possible bad expression ? dcb
@ 2014-12-15 20:32 ` Bastian Koppelmann
2014-12-15 20:40 ` Bastian Koppelmann
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Bastian Koppelmann @ 2014-12-15 20:32 UTC (permalink / raw)
To: qemu-devel
Absolutly correct. The mask should be 0x7f. I will fix that asap.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1402802
Title:
target-tricore/translate.c:3812: possible bad expression ?
Status in QEMU:
Confirmed
Bug description:
From a run of cppcheck, a static analysis checker, over the
source code of qemu trunk, dated 20141215, is the new error:
[qemu/target-tricore/translate.c:3812]: (style) Expression '(X & 0x3f)
== 0x6f' is always false.
Source code is
if (unlikely((op1 & 0x3f) == OPCM_32_BRN_JTT)) {
Suggest code rework.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1402802/+subscriptions
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [Bug 1402802] Re: target-tricore/translate.c:3812: possible bad expression ?
2014-12-15 19:31 [Qemu-devel] [Bug 1402802] [NEW] target-tricore/translate.c:3812: possible bad expression ? dcb
2014-12-15 20:32 ` [Qemu-devel] [Bug 1402802] " Bastian Koppelmann
@ 2014-12-15 20:40 ` Bastian Koppelmann
2014-12-22 14:55 ` Bastian Koppelmann
2016-06-21 5:40 ` T. Huth
3 siblings, 0 replies; 5+ messages in thread
From: Bastian Koppelmann @ 2014-12-15 20:40 UTC (permalink / raw)
To: qemu-devel
** Changed in: qemu
Status: New => Confirmed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1402802
Title:
target-tricore/translate.c:3812: possible bad expression ?
Status in QEMU:
Confirmed
Bug description:
From a run of cppcheck, a static analysis checker, over the
source code of qemu trunk, dated 20141215, is the new error:
[qemu/target-tricore/translate.c:3812]: (style) Expression '(X & 0x3f)
== 0x6f' is always false.
Source code is
if (unlikely((op1 & 0x3f) == OPCM_32_BRN_JTT)) {
Suggest code rework.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1402802/+subscriptions
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [Bug 1402802] Re: target-tricore/translate.c:3812: possible bad expression ?
2014-12-15 19:31 [Qemu-devel] [Bug 1402802] [NEW] target-tricore/translate.c:3812: possible bad expression ? dcb
2014-12-15 20:32 ` [Qemu-devel] [Bug 1402802] " Bastian Koppelmann
2014-12-15 20:40 ` Bastian Koppelmann
@ 2014-12-22 14:55 ` Bastian Koppelmann
2016-06-21 5:40 ` T. Huth
3 siblings, 0 replies; 5+ messages in thread
From: Bastian Koppelmann @ 2014-12-22 14:55 UTC (permalink / raw)
To: qemu-devel
** Changed in: qemu
Status: Confirmed => Fix Committed
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1402802
Title:
target-tricore/translate.c:3812: possible bad expression ?
Status in QEMU:
Fix Committed
Bug description:
From a run of cppcheck, a static analysis checker, over the
source code of qemu trunk, dated 20141215, is the new error:
[qemu/target-tricore/translate.c:3812]: (style) Expression '(X & 0x3f)
== 0x6f' is always false.
Source code is
if (unlikely((op1 & 0x3f) == OPCM_32_BRN_JTT)) {
Suggest code rework.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1402802/+subscriptions
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Qemu-devel] [Bug 1402802] Re: target-tricore/translate.c:3812: possible bad expression ?
2014-12-15 19:31 [Qemu-devel] [Bug 1402802] [NEW] target-tricore/translate.c:3812: possible bad expression ? dcb
` (2 preceding siblings ...)
2014-12-22 14:55 ` Bastian Koppelmann
@ 2016-06-21 5:40 ` T. Huth
3 siblings, 0 replies; 5+ messages in thread
From: T. Huth @ 2016-06-21 5:40 UTC (permalink / raw)
To: qemu-devel
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=7f13420ec000ad7644b65e
** Changed in: qemu
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1402802
Title:
target-tricore/translate.c:3812: possible bad expression ?
Status in QEMU:
Fix Released
Bug description:
From a run of cppcheck, a static analysis checker, over the
source code of qemu trunk, dated 20141215, is the new error:
[qemu/target-tricore/translate.c:3812]: (style) Expression '(X & 0x3f)
== 0x6f' is always false.
Source code is
if (unlikely((op1 & 0x3f) == OPCM_32_BRN_JTT)) {
Suggest code rework.
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1402802/+subscriptions
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-21 5:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-15 19:31 [Qemu-devel] [Bug 1402802] [NEW] target-tricore/translate.c:3812: possible bad expression ? dcb
2014-12-15 20:32 ` [Qemu-devel] [Bug 1402802] " Bastian Koppelmann
2014-12-15 20:40 ` Bastian Koppelmann
2014-12-22 14:55 ` Bastian Koppelmann
2016-06-21 5:40 ` T. Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).