From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0hiw-0006Sj-Do for qemu-devel@nongnu.org; Mon, 15 Dec 2014 21:18:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0hio-000712-RB for qemu-devel@nongnu.org; Mon, 15 Dec 2014 21:18:54 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:45523) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0hio-00070L-FR for qemu-devel@nongnu.org; Mon, 15 Dec 2014 21:18:46 -0500 Date: Tue, 16 Dec 2014 12:24:37 +1100 From: David Gibson Message-ID: <20141216012437.GH23547@voom.fritz.box> References: <1418690628-20652-1-git-send-email-david@gibson.dropbear.id.au> <1418690628-20652-2-git-send-email-david@gibson.dropbear.id.au> <548F83D5.3000903@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="iJXiJc/TAIT2rh2r" Content-Disposition: inline In-Reply-To: <548F83D5.3000903@suse.de> Subject: Re: [Qemu-devel] [PATCH 1/5] pseries: Move sPAPR RTC code into its own file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: aik@ozlabs.ru, paulus@samba.org, qemu-devel@nongnu.org, mdroth@us.ibm.com --iJXiJc/TAIT2rh2r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 16, 2014 at 01:59:01AM +0100, Alexander Graf wrote: >=20 >=20 > On 16.12.14 01:43, David Gibson wrote: > > At the moment the RTAS (firmware/hypervisor) time of day functions are > > implemented in spapr_rtas.c along with a bunch of other things. Since > > we're going to be expanding these a bit, move the RTAS RTC related code > > out into new file spapr_rtc.c. Also add its own initialization functio= n, > > spapr_rtc_init() called from the main machine init routine. > >=20 > > Signed-off-by: David Gibson > > --- > > hw/ppc/Makefile.objs | 2 +- > > hw/ppc/spapr.c | 3 ++ > > hw/ppc/spapr_rtas.c | 49 ----------------------------- > > hw/ppc/spapr_rtc.c | 83 ++++++++++++++++++++++++++++++++++++++++++= ++++++++ > > include/hw/ppc/spapr.h | 1 + > > 5 files changed, 88 insertions(+), 50 deletions(-) > > create mode 100644 hw/ppc/spapr_rtc.c > >=20 > > diff --git a/hw/ppc/Makefile.objs b/hw/ppc/Makefile.objs > > index 19d9920..437955d 100644 > > --- a/hw/ppc/Makefile.objs > > +++ b/hw/ppc/Makefile.objs > > @@ -3,7 +3,7 @@ obj-y +=3D ppc.o ppc_booke.o > > # IBM pSeries (sPAPR) > > obj-$(CONFIG_PSERIES) +=3D spapr.o spapr_vio.o spapr_events.o > > obj-$(CONFIG_PSERIES) +=3D spapr_hcall.o spapr_iommu.o spapr_rtas.o > > -obj-$(CONFIG_PSERIES) +=3D spapr_pci.o > > +obj-$(CONFIG_PSERIES) +=3D spapr_pci.o spapr_rtc.o > > ifeq ($(CONFIG_PCI)$(CONFIG_PSERIES)$(CONFIG_LINUX), yyy) > > obj-y +=3D spapr_pci_vfio.o > > endif > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > index 30de25d..16377a3 100644 > > --- a/hw/ppc/spapr.c > > +++ b/hw/ppc/spapr.c > > @@ -1446,6 +1446,9 @@ static void ppc_spapr_init(MachineState *machine) > > /* Set up EPOW events infrastructure */ > > spapr_events_init(spapr); > > =20 > > + /* Set up the RTC RTAS interfaces */ > > + spapr_rtc_init(); >=20 > Do you think we could make it a device instead? Um.. I guess. Is there a standard place to put such pseudo-devices in the bus heirarchy? --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --iJXiJc/TAIT2rh2r Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUj4nVAAoJEGw4ysog2bOSGQ0QANX2CTUgJq7OmffZnat91kfz 365FsIZO4jkEg0qS4ntVH4eIA6D+UbR9RyE6R+7bKS2al+3gPd3EepLkKQr6SqaQ lYO/aLf71CaJ2dwjRhTWGsh+AI1EMxmPsC/j//uqQEvUIJW2RmE0X5XYrfjwcSwU UevDY3xcojG0FYgBO9vbMMEAai0fUwvhy/sjyPXrhmcIo1nXHi5zRhCdwNwZvxyH 0lGOUjG6r9xQv+yVWtlkemOgk1H2apSdMpLadc4iAE7cfKE3sWjogEDfALqKkhqG 8heE7E6qlO/ZwUpsaGmoqcTC1UFfkbDcsFZoxFgbYCbfhVDUumzxVtFV+Dpc6qkt pXy/Imeel+9TCZ94bqph7RKcPGfA/qCfbEAWPVJ+3GYinboFkFB4jQyN9jdtwllW qEwZPylZeL6s1JssAmfu2i/EG0j8iDv2vYUTeElo+TmAb1eq/TJBqMnWYsqAb+C1 ZbT8jSLweyFpTg3nBrLAiWPsz9L3I9y9PqL/+Fc5OJAiusKnvlryTfP2qj1XJ4UJ B0TymYNKu+iDVy27hok2zAyF3veX/vVwc7AFwi6z9uFsm3FW24ZT7Uv7FHRGUYcy oClH0B8hnCI9lGYyvF6qBMsdU6LT23R3cIb5gK/HoIw7F+vsBWGYcdUK7uF83etm h6kWaT7g6hQsJIbgyo+P =ewR+ -----END PGP SIGNATURE----- --iJXiJc/TAIT2rh2r--