From: Frank Blaschka <blaschka@linux.vnet.ibm.com>
To: Alexander Graf <agraf@suse.de>
Cc: "cornelia.huck@de.ibm.com" <cornelia.huck@de.ibm.com>,
"borntraeger@de.ibm.com" <borntraeger@de.ibm.com>,
Frank Blaschka <frank.blaschka@de.ibm.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"peter.maydell@linaro.org" <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] s390/pci: fix build on 32-bit and non linux
Date: Tue, 16 Dec 2014 13:13:08 +0100 [thread overview]
Message-ID: <20141216121308.GA23123@tuxmaker.boeblingen.de.ibm.com> (raw)
In-Reply-To: <54901E0A.7000704@suse.de>
On Tue, Dec 16, 2014 at 12:56:58PM +0100, Alexander Graf wrote:
>
>
> On 16.12.14 12:46, Frank Blaschka wrote:
> > On Tue, Dec 16, 2014 at 11:35:19AM +0100, Alexander Graf wrote:
> >>
> >>
> >>
> >>> Am 16.12.2014 um 10:28 schrieb Frank Blaschka <blaschka@linux.vnet.ibm.com>:
> >>>
> >>> From: Frank Blaschka <frank.blaschka@de.ibm.com>
> >>>
> >>> Remove unnecessary and wrong includes. Fix get_rt_sto and
> >>> get_st_pto to build on 32-bit.
> >>>
> >>> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com>
> >>
> >> Could you please roll the fixes into the offending patches and repost the set? Otherwise we break bisectability on 32bit hosts.
> >>
> >
> > Sure, but since this is an initial drop and I have to touch the patches anyhow can I merge all
> > add-ons and fixes to the initial patch set?
> >
> > I would like to end up finally with just 3 patches:
> >
> > s390: Add PCI bus support
> > s390: implement pci instructions
> > kvm: extend kvm_irqchip_add_msi_route to work on s390
> >
> > If so I would post V2 of the initial patch set including all changes.
>
> Cornelia is the maintainer here, so you'll need to ask her :). Anything
> that doesn't break bisectability is certainly better than code that
> breaks it.
>
OK. Coni what do you prefere?
> By squashing all those patches together you'll make bisecting harder for
> s390 - if you can live with it so can I.
>
>
> Alex
>
next prev parent reply other threads:[~2014-12-16 12:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 9:28 [Qemu-devel] [PATCH] s390/pci: fix build on 32-bit and non linux Frank Blaschka
2014-12-16 10:35 ` Alexander Graf
2014-12-16 11:46 ` Frank Blaschka
2014-12-16 11:56 ` Alexander Graf
2014-12-16 12:13 ` Frank Blaschka [this message]
2014-12-16 12:13 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216121308.GA23123@tuxmaker.boeblingen.de.ibm.com \
--to=blaschka@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=frank.blaschka@de.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).