From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0r0F-00022w-FM for qemu-devel@nongnu.org; Tue, 16 Dec 2014 07:13:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0r06-0003vA-E0 for qemu-devel@nongnu.org; Tue, 16 Dec 2014 07:13:23 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:54983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0r06-0003v4-4u for qemu-devel@nongnu.org; Tue, 16 Dec 2014 07:13:14 -0500 Received: from /spool/local by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 16 Dec 2014 12:13:12 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6A1AA2190046 for ; Tue, 16 Dec 2014 12:12:40 +0000 (GMT) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sBGCD9qM43122864 for ; Tue, 16 Dec 2014 12:13:09 GMT Received: from d06av05.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sBGCD9GN029478 for ; Tue, 16 Dec 2014 05:13:09 -0700 Date: Tue, 16 Dec 2014 13:13:08 +0100 From: Frank Blaschka Message-ID: <20141216121308.GA23123@tuxmaker.boeblingen.de.ibm.com> References: <1418722138-37222-1-git-send-email-blaschka@linux.vnet.ibm.com> <20141216114649.GA53045@tuxmaker.boeblingen.de.ibm.com> <54901E0A.7000704@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54901E0A.7000704@suse.de> Subject: Re: [Qemu-devel] [PATCH] s390/pci: fix build on 32-bit and non linux List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "cornelia.huck@de.ibm.com" , "borntraeger@de.ibm.com" , Frank Blaschka , "qemu-devel@nongnu.org" , "peter.maydell@linaro.org" On Tue, Dec 16, 2014 at 12:56:58PM +0100, Alexander Graf wrote: > > > On 16.12.14 12:46, Frank Blaschka wrote: > > On Tue, Dec 16, 2014 at 11:35:19AM +0100, Alexander Graf wrote: > >> > >> > >> > >>> Am 16.12.2014 um 10:28 schrieb Frank Blaschka : > >>> > >>> From: Frank Blaschka > >>> > >>> Remove unnecessary and wrong includes. Fix get_rt_sto and > >>> get_st_pto to build on 32-bit. > >>> > >>> Signed-off-by: Frank Blaschka > >> > >> Could you please roll the fixes into the offending patches and repost the set? Otherwise we break bisectability on 32bit hosts. > >> > > > > Sure, but since this is an initial drop and I have to touch the patches anyhow can I merge all > > add-ons and fixes to the initial patch set? > > > > I would like to end up finally with just 3 patches: > > > > s390: Add PCI bus support > > s390: implement pci instructions > > kvm: extend kvm_irqchip_add_msi_route to work on s390 > > > > If so I would post V2 of the initial patch set including all changes. > > Cornelia is the maintainer here, so you'll need to ask her :). Anything > that doesn't break bisectability is certainly better than code that > breaks it. > OK. Coni what do you prefere? > By squashing all those patches together you'll make bisecting harder for > s390 - if you can live with it so can I. > > > Alex >