From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: thuth@linux.vnet.ibm.com, rusty@rustcorp.com.au,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org
Subject: Re: [Qemu-devel] [PATCH RFC v6 17/20] virtio-net: enable virtio 1.0
Date: Tue, 16 Dec 2014 15:10:04 +0200 [thread overview]
Message-ID: <20141216131004.GA4504@redhat.com> (raw)
In-Reply-To: <1418304322-7546-18-git-send-email-cornelia.huck@de.ibm.com>
On Thu, Dec 11, 2014 at 02:25:19PM +0100, Cornelia Huck wrote:
> virtio-net (non-vhost) now should have everything in place to support
> virtio 1.0: let's enable the feature bit for it.
>
> Note that VIRTIO_F_VERSION_1 is technically a transport feature; once
> every device is ready for virtio 1.0, we can move setting this
> feature bit out of the individual devices.
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
So to use this with e.g. tun, you need to make tun device LE.
I posted a kernel patch 1418732988-3535-1-git-send-email-mst@redhat.com
with TUNSETVNETLE/TUNGETVNETLE ioctls to support it.
But you still need to call them in qemu, and disable virtio-1.0
if not there.
> ---
> hw/net/virtio-net.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index 7ee2bd6..b5dd356 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -473,6 +473,7 @@ static uint64_t virtio_net_get_features(VirtIODevice *vdev, uint64_t features)
> }
>
> if (!get_vhost_net(nc->peer)) {
> + virtio_add_feature(&features, VIRTIO_F_VERSION_1);
> return features;
> }
> return vhost_net_get_features(get_vhost_net(nc->peer), features);
> --
> 1.7.9.5
next prev parent reply other threads:[~2014-12-16 13:10 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 13:25 [Qemu-devel] [PATCH RFC v6 00/20] qemu: towards virtio-1 host support Cornelia Huck
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 01/20] linux-headers/virtio_config: Update with VIRTIO_F_VERSION_1 Cornelia Huck
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 02/20] virtio: cull virtio_bus_set_vdev_features Cornelia Huck
2015-01-22 1:24 ` David Gibson
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 03/20] virtio: feature bit manipulation helpers Cornelia Huck
2014-12-11 14:29 ` Thomas Huth
2015-01-22 1:25 ` David Gibson
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 04/20] virtio: add feature checking helpers Cornelia Huck
2014-12-11 14:46 ` Thomas Huth
2014-12-11 17:05 ` Michael S. Tsirkin
2014-12-12 8:37 ` Cornelia Huck
2014-12-12 10:07 ` Cornelia Huck
2015-01-22 1:28 ` David Gibson
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 05/20] virtio: support more feature bits Cornelia Huck
2014-12-12 10:06 ` Thomas Huth
2014-12-12 10:17 ` Cornelia Huck
2015-01-22 1:40 ` David Gibson
2015-01-22 1:43 ` David Gibson
2015-01-28 15:59 ` Cornelia Huck
2015-01-29 0:11 ` David Gibson
2015-01-29 9:24 ` Thomas Huth
2015-01-29 10:01 ` David Gibson
2015-01-29 10:54 ` Michael S. Tsirkin
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 06/20] virtio: endianness checks for virtio 1.0 devices Cornelia Huck
2015-01-20 10:29 ` Stefan Hajnoczi
2015-01-22 1:54 ` David Gibson
2015-01-23 16:09 ` Greg Kurz
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 07/20] virtio: allow virtio-1 queue layout Cornelia Huck
2015-01-22 2:06 ` David Gibson
2015-01-28 16:07 ` Cornelia Huck
2015-01-29 0:14 ` David Gibson
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 08/20] dataplane: allow virtio-1 devices Cornelia Huck
2015-01-20 10:43 ` Stefan Hajnoczi
2015-01-20 12:56 ` Cornelia Huck
2015-01-20 14:47 ` Stefan Hajnoczi
2015-01-22 2:12 ` David Gibson
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 09/20] s390x/css: Add a callback for when subchannel gets disabled Cornelia Huck
2015-01-20 10:50 ` Stefan Hajnoczi
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 10/20] s390x/virtio-ccw: add virtio set-revision call Cornelia Huck
2015-01-20 11:00 ` Stefan Hajnoczi
2015-01-20 11:08 ` Stefan Hajnoczi
2015-01-21 11:23 ` Cornelia Huck
2015-01-21 11:51 ` Thomas Huth
2015-01-21 12:39 ` Cornelia Huck
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 11/20] s390x/virtio-ccw: support virtio-1 set_vq format Cornelia Huck
2015-01-20 11:06 ` Stefan Hajnoczi
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 12/20] virtio: disallow late feature changes for virtio-1 Cornelia Huck
2014-12-12 10:55 ` Thomas Huth
2014-12-12 11:18 ` Cornelia Huck
2014-12-12 11:25 ` Thomas Huth
2015-01-20 11:14 ` Stefan Hajnoczi
2015-01-22 2:15 ` David Gibson
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 13/20] virtio: allow to fail setting status Cornelia Huck
2014-12-30 12:25 ` Michael S. Tsirkin
2015-01-07 16:13 ` Cornelia Huck
2015-01-07 19:08 ` Michael S. Tsirkin
2015-01-08 7:20 ` Cornelia Huck
2015-01-08 8:09 ` Michael S. Tsirkin
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 14/20] s390x/virtio-ccw: enable virtio 1.0 Cornelia Huck
2015-01-20 11:15 ` Stefan Hajnoczi
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 15/20] virtio-net: no writeable mac for virtio-1 Cornelia Huck
2015-01-20 11:19 ` Stefan Hajnoczi
2015-01-22 16:31 ` Cornelia Huck
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 16/20] virtio-net: support longer header Cornelia Huck
2015-01-20 13:18 ` Stefan Hajnoczi
2015-01-21 16:06 ` Cornelia Huck
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 17/20] virtio-net: enable virtio 1.0 Cornelia Huck
2014-12-16 13:10 ` Michael S. Tsirkin [this message]
2014-12-18 16:57 ` Cornelia Huck
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 18/20] virtio: support revision-specific features Cornelia Huck
2014-12-28 8:32 ` Michael S. Tsirkin
2015-01-07 16:22 ` Cornelia Huck
2015-01-07 19:10 ` Michael S. Tsirkin
2015-01-30 14:08 ` Cornelia Huck
2015-02-01 21:29 ` Michael S. Tsirkin
2015-02-02 14:10 ` Cornelia Huck
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 19/20] virtio-blk: revision specific feature bits Cornelia Huck
2014-12-28 10:24 ` Michael S. Tsirkin
2015-01-07 16:29 ` Cornelia Huck
2015-01-07 19:11 ` Michael S. Tsirkin
2015-01-30 14:10 ` Cornelia Huck
2014-12-11 13:25 ` [Qemu-devel] [PATCH RFC v6 20/20] vhost: 64 bit features Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141216131004.GA4504@redhat.com \
--to=mst@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=thuth@linux.vnet.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).