qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: "Thebault, Remi" <remi.thebault@outlook.com>
Cc: sw@weilnetz.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] alt-gr on Windows
Date: Thu, 18 Dec 2014 12:55:28 +0100	[thread overview]
Message-ID: <20141218115528.GB25902@noname.redhat.com> (raw)
In-Reply-To: <BLU436-SMTP559581A02F5F1AF0DEA226F66D0@phx.gbl>

Am 17.12.2014 um 01:11 hat Thebault, Remi geschrieben:
> Hi list!
> 
> This is not the first post on this topic, but I haven't seen any
> solution about it.
> I tested so far linux guest on windows host and the AltGr key is
> dead in the guest. (using git master branch)
> 
> On french keyboard, the keys to yield the bar "|" are alt-gr + 6.
> when executing this combination on keyboard, Windows generates this:
>     - L-CTRL
>     - R-ALT
>     - 6
> 
> in Qemu (only digged gtk UI so far), pressing alt-gr + 6 generates
> the following trace
>     - L-CTRL
>     - L-ALT   <-- note left here
>     - 6
> 
> This comes from the Win32 call MapVirtualKey in gtk.c that maps to
> scancodes without left/right distinction.
> Even when sending the right alt to the guest, the alt-gr key remains
> dead because of ctrl being virtually pressed. I found out however
> that if R-ALT + 6 is sent without the ctrl key, the guest finally
> recognize it and prints the bar, @, # and other [}{].
> 
> To make things easier, Windows delivers the ctrl code before the alt
> code, so catching it cleanly before delivery to the guest is
> probably tough.
> I could however come to an easy and quick fix with sending the "ctrl
> up" signal to the guest before the "r-alt down" is sent.
> 
> My current code do not handle all corner cases (eg: turbo mode) and
> only fixes the gtk ui, but would such fix be accepted in the repo?
> Would this break somehow the windows guest on windows host?

CCing Stefan Weil, who is both the Windows maintainer and the author of
commit 2777ccc5, which introduced the MapVirtualKey() call. As there is
a special case for Alt Gr in the code, I suppose he had this working
back then.

>From what I understand (which isn't much when it's about Windows), it
seems very unlikely to me that the change would break anything that is
working today; but you should probably give it some testing before
posting a patch.

Kevin

  reply	other threads:[~2014-12-18 11:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-17  0:11 [Qemu-devel] alt-gr on Windows Thebault, Remi
2014-12-18 11:55 ` Kevin Wolf [this message]
2014-12-21 17:54   ` Thebault, Remi
2015-01-01 16:24   ` Andreas Färber
2015-01-01 19:10     ` Stefan Weil
2015-01-25 16:36       ` [Qemu-devel] [PATCH v2] " Thebault, Remi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141218115528.GB25902@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=remi.thebault@outlook.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).