From: Stefan Hajnoczi <stefanha@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gabriel Somlo <somlo@cmu.edu>, Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
akong@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] e1000: defer packets until BM enabled
Date: Fri, 19 Dec 2014 13:17:11 +0000 [thread overview]
Message-ID: <20141219131711.GA25519@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1417457142-30160-1-git-send-email-mst@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
On Mon, Dec 01, 2014 at 08:06:52PM +0200, Michael S. Tsirkin wrote:
> Some guests seem to set BM for e1000 after
> enabling RX.
> If packets arrive in the window, device is wedged.
> Probably works by luck on real hardware, work around
> this by making can_receive depend on BM.
>
> Tested-by: Gabriel Somlo <somlo@cmu.edu>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>
> Amos - you were the one reporting the failures, could
> you pls confirm this patch fixes the issues for you?
>
> hw/net/e1000.c | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2014-12-19 13:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 18:06 [Qemu-devel] [PATCH v2] e1000: defer packets until BM enabled Michael S. Tsirkin
2014-12-02 9:06 ` Jason Wang
2014-12-19 13:17 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219131711.GA25519@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=agraf@suse.de \
--cc=akong@redhat.com \
--cc=kraxel@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=somlo@cmu.edu \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).