From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53079)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Y1xQm-00011d-SL
	for qemu-devel@nongnu.org; Fri, 19 Dec 2014 08:17:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Y1xQg-0007w9-QR
	for qemu-devel@nongnu.org; Fri, 19 Dec 2014 08:17:20 -0500
Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:40919)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1Y1xQg-0007w3-JP
	for qemu-devel@nongnu.org; Fri, 19 Dec 2014 08:17:14 -0500
Received: by mail-wi0-f180.google.com with SMTP id n3so1736531wiv.7
	for <qemu-devel@nongnu.org>; Fri, 19 Dec 2014 05:17:14 -0800 (PST)
Date: Fri, 19 Dec 2014 13:17:11 +0000
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20141219131711.GA25519@stefanha-thinkpad.redhat.com>
References: <1417457142-30160-1-git-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="FL5UXtIhxfXey3p5"
Content-Disposition: inline
In-Reply-To: <1417457142-30160-1-git-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] e1000: defer packets until BM enabled
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Gabriel Somlo <somlo@cmu.edu>, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, akong@redhat.com


--FL5UXtIhxfXey3p5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 01, 2014 at 08:06:52PM +0200, Michael S. Tsirkin wrote:
> Some guests seem to set BM for e1000 after
> enabling RX.
> If packets arrive in the window, device is wedged.
> Probably works by luck on real hardware, work around
> this by making can_receive depend on BM.
>=20
> Tested-by: Gabriel Somlo <somlo@cmu.edu>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>=20
> Amos - you were the one reporting the failures, could
> you pls confirm this patch fixes the issues for you?
>=20
>  hw/net/e1000.c | 21 ++++++++++++++++++++-
>  1 file changed, 20 insertions(+), 1 deletion(-)

Thanks, applied to my net tree:
https://github.com/stefanha/qemu/commits/net

Stefan

--FL5UXtIhxfXey3p5
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUlCVXAAoJEJykq7OBq3PILOkH/inxD7bOO2B3VdUgb6pjbtT/
Oyvb5cEY4WOIwlAFgUyZY77eMXAxVeesgCDT+5Tk7qbIq/UwtrcUxbKLRgeD8Rdl
hbH8UyLyK1JesxwtT2owU/OaSKnoHPbNnlOrjVLq12CbC9sN81ctr1OxPR55a8LD
R2a19iFNwE1qqKSXwXlfaqiiYj249oljxm6uPBwIsSftyLxdiwKK8rzZZ5BnHuSQ
GAvs/M2me/tLNfx/lTzTDlCAZRWQCjT0uZ1XwavKCqy0e3dTrYxcRyvI8si8qIex
k2kUOz5l0LgVJ19/NhiRkF4D9Ee88Jntfi0ZsN4IekYYGvBOuU9NmUDV2GsYibU=
=fza2
-----END PGP SIGNATURE-----

--FL5UXtIhxfXey3p5--