From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com
Subject: [Qemu-devel] [PULL 02/14] vfio: fix adding memory listener to the right address space
Date: Mon, 22 Dec 2014 13:43:21 -0700 [thread overview]
Message-ID: <20141222204321.31398.61715.stgit@bling.home> (raw)
In-Reply-To: <20141222204144.31398.31803.stgit@bling.home>
From: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Depending on the device, container->space->as contains the valid AddressSpace.
Using address_space_memory breaks devices sitting behind an iommu (and using
a separate address space).
Signed-off-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
hw/misc/vfio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/vfio.c b/hw/misc/vfio.c
index 6c36c8b..51844cf 100644
--- a/hw/misc/vfio.c
+++ b/hw/misc/vfio.c
@@ -3713,7 +3713,7 @@ static int vfio_connect_container(VFIOGroup *group, AddressSpace *as)
container->iommu_data.release = vfio_listener_release;
memory_listener_register(&container->iommu_data.type1.listener,
- &address_space_memory);
+ container->space->as);
if (container->iommu_data.type1.error) {
ret = container->iommu_data.type1.error;
next prev parent reply other threads:[~2014-12-22 20:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 20:43 [Qemu-devel] [PULL 00/14] QEMU: VFIO updates Alex Williamson
2014-12-22 20:43 ` [Qemu-devel] [PULL 01/14] vfio: migration to trace points Alex Williamson
2014-12-22 20:43 ` Alex Williamson [this message]
2014-12-22 20:43 ` [Qemu-devel] [PULL 03/14] vfio: move hw/misc/vfio.c to hw/vfio/pci.c Move vfio.h into include/hw/vfio Alex Williamson
2014-12-22 20:43 ` [Qemu-devel] [PULL 04/14] hw/vfio/pci: Rename VFIODevice into VFIOPCIDevice Alex Williamson
2014-12-22 20:43 ` [Qemu-devel] [PULL 05/14] hw/vfio/pci: generalize mask/unmask to any IRQ index Alex Williamson
2014-12-22 20:43 ` [Qemu-devel] [PULL 06/14] hw/vfio/pci: introduce minimalist VFIODevice with fd Alex Williamson
2014-12-22 20:43 ` [Qemu-devel] [PULL 07/14] hw/vfio/pci: add type, name and group fields in VFIODevice Alex Williamson
2014-12-22 20:43 ` [Qemu-devel] [PULL 08/14] hw/vfio/pci: handle reset at VFIODevice Alex Williamson
2014-12-22 20:44 ` [Qemu-devel] [PULL 09/14] hw/vfio/pci: Introduce VFIORegion Alex Williamson
2014-12-22 20:44 ` [Qemu-devel] [PULL 10/14] hw/vfio/pci: split vfio_get_device Alex Williamson
2014-12-22 20:44 ` [Qemu-devel] [PULL 11/14] hw/vfio/pci: rename group_list into vfio_group_list Alex Williamson
2014-12-22 20:44 ` [Qemu-devel] [PULL 12/14] hw/vfio/pci: use name field in format strings Alex Williamson
2014-12-22 20:44 ` [Qemu-devel] [PULL 13/14] hw/vfio: create common module Alex Williamson
2014-12-22 20:44 ` [Qemu-devel] [PULL 14/14] vfio: Cleanup error_report()s Alex Williamson
2014-12-23 15:05 ` [Qemu-devel] [PULL 00/14] QEMU: VFIO updates Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141222204321.31398.61715.stgit@bling.home \
--to=alex.williamson@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).