From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y39qL-0008Hi-P9 for qemu-devel@nongnu.org; Mon, 22 Dec 2014 15:44:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y39qF-0008De-EZ for qemu-devel@nongnu.org; Mon, 22 Dec 2014 15:44:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:58542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y39qF-0008DU-55 for qemu-devel@nongnu.org; Mon, 22 Dec 2014 15:44:35 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sBMKiYpF011743 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 22 Dec 2014 15:44:34 -0500 From: Alex Williamson Date: Mon, 22 Dec 2014 13:44:34 -0700 Message-ID: <20141222204433.31398.14997.stgit@bling.home> In-Reply-To: <20141222204144.31398.31803.stgit@bling.home> References: <20141222204144.31398.31803.stgit@bling.home> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PULL 14/14] vfio: Cleanup error_report()s List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: alex.williamson@redhat.com With the conversion to tracepoints, a couple previous DPRINTKs are now quite a bit more visible and are really just informational. Remove these and add a bit more description to another. Signed-off-by: Alex Williamson --- hw/vfio/common.c | 2 +- hw/vfio/pci.c | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index 4f15c86..cf483ff 100644 --- a/hw/vfio/common.c +++ b/hw/vfio/common.c @@ -566,7 +566,7 @@ static void vfio_kvm_device_add_group(VFIOGroup *group) }; if (kvm_vm_ioctl(kvm_state, KVM_CREATE_DEVICE, &cd)) { - error_report("KVM_CREATE_DEVICE: %m\n"); + error_report("Failed to create KVM VFIO device: %m\n"); return; } diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index e380959..b4e73d1 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -2801,8 +2801,6 @@ static int vfio_pci_hot_reset(VFIOPCIDevice *vdev, bool single) tmp = container_of(vbasedev_iter, VFIOPCIDevice, vbasedev); if (vfio_pci_host_match(&host, &tmp->host)) { if (single) { - error_report("vfio: found another in-use device " - "%s\n", vbasedev_iter->name); ret = -EINVAL; goto out_single; } @@ -2815,7 +2813,6 @@ static int vfio_pci_hot_reset(VFIOPCIDevice *vdev, bool single) } if (!single && !multi) { - error_report("vfio: No other in-use devices for multi hot reset\n"); ret = -EINVAL; goto out_single; }