From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3F0e-0001vY-SO for qemu-devel@nongnu.org; Mon, 22 Dec 2014 21:15:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y3F0a-000407-1W for qemu-devel@nongnu.org; Mon, 22 Dec 2014 21:15:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37668) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3F0Z-000400-P8 for qemu-devel@nongnu.org; Mon, 22 Dec 2014 21:15:35 -0500 Date: Tue, 23 Dec 2014 10:15:28 +0800 From: Fam Zheng Message-ID: <20141223021528.GG4021@ad.nay.redhat.com> References: <1419006909-1781-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL 00/19] Block patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Kevin Wolf , QEMU Developers On Mon, 12/22 12:22, Peter Maydell wrote: > On 22 December 2014 at 12:07, Peter Maydell wrote: > > Something very odd is happening here: why are all the "r"s apparently > > missing from those error messages? > > Looks like the result of using GNU sed-isms in some of the filters. On OSX: > > $ echo "art trick" | sed -e 's/\r//g' > at tick > > On Linux with GNU sed: > $ echo "art trick" | sed -e 's/\r//g' > art trick > > This likely breaks on the BSDs too. I suspect these scripts need > a careful overhaul before we can add them to 'make check' :-( > Oops! Thanks Peter, I'll take care of it and respin. We should drop these patches from this PULL for now. Fam