From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3Fw3-0004iv-Ge for qemu-devel@nongnu.org; Mon, 22 Dec 2014 22:15:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y3Fw2-0003oS-Fn for qemu-devel@nongnu.org; Mon, 22 Dec 2014 22:14:59 -0500 Date: Tue, 23 Dec 2014 14:14:56 +1100 From: David Gibson Message-ID: <20141223031456.GB4576@voom.redhat.com> References: <1419293824-2654-1-git-send-email-david@gibson.dropbear.id.au> <1419293824-2654-9-git-send-email-david@gibson.dropbear.id.au> <5498B6D2.5040406@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Content-Disposition: inline In-Reply-To: <5498B6D2.5040406@suse.de> Subject: Re: [Qemu-devel] [PATCHv2 8/8] pseries: Export RTC time via QOM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, mdroth@us.ibm.com, amit.shah@redhat.com, pbonzini@redhat.com --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 23, 2014 at 01:26:58AM +0100, Alexander Graf wrote: >=20 >=20 > On 23.12.14 01:17, David Gibson wrote: > > On x86, the guest's RTC can be read with QMP, either from the RTC devic= e's > > "date" property or via the "rtc-time" property on the machine (which is= an > > alias to the former). This is set up in the mc146818rtc driver, and > > doesn't work on other targets. > >=20 > > This patch adds a similar "date" property to the pseries machine's RTAS= RTC > > and adds a compatible alias to the machine. > >=20 > > Signed-off-by: David Gibson >=20 > Very nice, can we somehow get rid of an exported spapr_rtc_read() with > this as well? Uhhh.. we could, but I really don't like the idea. It seems perverse to encode the current time into JSON, just so we can decode it into a struct tm again in the events code. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUmN4wAAoJEGw4ysog2bOSn3QP/R53ApT0g4/DGBCYW7/5bWBV 47aI6cfO/QHIIbeLGKYeKa/XYTq/D8gzjDZ799mZWnpWOnYFHDJ4QrLtJ0P7bqd1 cDJ22qETI6Q/erl4TpmrtOmyXm0vK3YUzk9mYknWhQo7J0STyqX4gfn9Hjs+9yfJ b6z0u4dnfr3/eF/TYDQdPeLpD0Qg7l6Le2yWtVY+6CvBFA5XF0yuxCEWyZ07MoeG V2ekEw9HMCyGJBRjtmbQyDGVp7HRAAWs8XXWXi0wiEcAMQXoE2zCuAEPrgPNb0Iz VYSWmf2mosWuz4hEXxzJ3TTQTyEXoRT/jbInYqZTvKgvTX1A59YriaOtJSeq1+9f yBAxcPZ2XkDnapGui7+j0+bmXdUgFMHnJu0YKLAkBLNYuSiOcy55M1zps+ld7NjV CTCZZTxXnRgdVECGGilF1cpoeSUQz9BtPIFXKj4UIqOhC6o/81LaVCHu+RtieE/K 3VgTHViungmjEYZoU3d22Vzz63jKpqXaFL2vqP+1hYOtXGPTsr01JsP8vHmOf/Kq FcXoZT5lgcMwQn/U5bYl5U0bwQxXRFh0OBWuMhIqGkViefUoR5OMnhRydxJsNzDX 8FQyT2AHIB9AYM6KVk/6JWRbSItKQHEvgSYkQUs38wgE7MN3GoEu/4n/bX4dnD1l MIlobE6JN3I48OwqVWGL =S3Eg -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg--