From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3IRA-0000C9-RR for qemu-devel@nongnu.org; Tue, 23 Dec 2014 00:55:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y3IR2-0001KO-3l for qemu-devel@nongnu.org; Tue, 23 Dec 2014 00:55:16 -0500 Received: from mail-la0-x236.google.com ([2a00:1450:4010:c03::236]:60809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3IR1-0001HP-SP for qemu-devel@nongnu.org; Tue, 23 Dec 2014 00:55:08 -0500 Received: by mail-la0-f54.google.com with SMTP id pv20so4972429lab.27 for ; Mon, 22 Dec 2014 21:55:06 -0800 (PST) Date: Tue, 23 Dec 2014 07:52:46 +0200 From: Alex Suykov Message-ID: <20141223055246.GA31216@vostro> References: <20141221110217.GA14555@vostro> <20141223015957.GC4021@ad.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20141223015957.GC4021@ad.nay.redhat.com> Subject: Re: [Qemu-devel] [PATCH] linux-user: support target-to-host SCM_CREDENTIALS List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Riku Voipio , qemu-devel@nongnu.org Tue, Dec 23, 2014 at 09:59:57AM +0800, Fam Zheng wrote: > On Sun, 12/21 13:02, Alex Suykov wrote: > > When passing ancillary data through a unix socket, handle > > credentials properly instead of doing a simple copy and > > issuing a warning. > > > > Signed-off-by: Alex Suykov > > --- ... > > - gemu_log("Unsupported ancillary data: %d/%d\n", cmsg->cmsg_level, cmsg->cmsg_type); ... > > + gemu_log("Unsupported ancillary data: %d/%d\n", cmsg->cmsg_level, cmsg->cmsg_type); ... > > I didn't review the code but checkpatch.pl complains about a few lines over 80 > characters. The patch does not change the length of the longest line in that function, just moves it around. So my guess was that mixing semantic changes and reformatting is not a good idea. Sending checkpatch-compliant v2.