From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3Q3i-00048i-PM for qemu-devel@nongnu.org; Tue, 23 Dec 2014 09:03:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y3Q3e-0004x0-78 for qemu-devel@nongnu.org; Tue, 23 Dec 2014 09:03:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36349) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3Q3e-0004w9-0W for qemu-devel@nongnu.org; Tue, 23 Dec 2014 09:03:30 -0500 Date: Tue, 23 Dec 2014 09:03:22 -0500 From: Jeff Cody Message-ID: <20141223140322.GA21036@localhost.localdomain> References: <5e582703e36450b9ca939e2e5c9fa3930030f7fe.1418018421.git.jcody@redhat.com> <54856647.1020509@redhat.com> <54895E8B.40900@redhat.com> <20141212151742.GA15426@localhost.localdomain> <20141217121420.GA519@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/4] block: vhdx - set .bdrv_has_zero_init to bdrv_has_zero_init_1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Lokesha, Amulya" Cc: "kwolf@redhat.com" , "qemu-devel@nongnu.org" , "stefanha@redhat.com" , Max Reitz On Tue, Dec 23, 2014 at 05:07:16AM -0500, Lokesha, Amulya wrote: >=20 > -----Original Message----- > From: Jeff Cody [mailto:jcody@redhat.com]=20 > Sent: Wednesday, December 17, 2014 5:44 PM > To: Lokesha, Amulya > Cc: Max Reitz; qemu-devel@nongnu.org; kwolf@redhat.com; stefanha@redhat= .com > Subject: Re: [PATCH 4/4] block: vhdx - set .bdrv_has_zero_init to bdrv_= has_zero_init_1 >=20 > On Wed, Dec 17, 2014 at 05:46:32AM -0500, Lokesha, Amulya wrote: > > Hi Max, Jeff, > >=20 > > We were able to get the qemu patch files downloaded from the qemu pat= ch site - https://patchwork.ozlabs.org and were able to apply the patche= s successfully without any errors. With the patches applied, we recompile= d the qemu and converted the VDK vmdk to vhdx format and uploaded to the = SCVMM Server. But it failed again with the syntax error as below: > >=20 > > Information (10804) > > Unable to import \\TestServer\MSSCVMMLibrary\VHDs\Product-disk1.vhdx = because of a syntax error in the file. > >=20 > > Please find my comments inline for your questions > >=20 > > Please let us know if there is anything else you need from us. > >=20 > > >=20 > Amulya, >=20 > I will try to test this on Windows Server, and see if I can reproduce w= hat you are seeing. >=20 > -Jeff >=20 >=20 > Hi Jeff, >=20 > Any updates on this? Were you able to test it >=20 > Thanks, > Amulya > Still in process. I am working to get some MSDN licensing issues resolved, and then I will be able to test. >=20 > >=20 > >=20 > > -----Original Message----- > > From: Jeff Cody [mailto:jcody@redhat.com] > > Sent: Friday, December 12, 2014 8:48 PM > > To: Lokesha, Amulya > > Cc: Max Reitz; qemu-devel@nongnu.org; kwolf@redhat.com;=20 > > stefanha@redhat.com > > Subject: Re: [PATCH 4/4] block: vhdx - set .bdrv_has_zero_init to=20 > > bdrv_has_zero_init_1 > >=20 > > On Fri, Dec 12, 2014 at 09:43:16AM -0500, Lokesha, Amulya wrote: > > > Hi Max, > > >=20 > > > =A0 > >=20 > > Please reply in-line, it makes it easier to follow technical=20 > > discussions - thanks :) > >=20 > > >=20 > > > We applied all the 5 patches from the mail chain I got since the= last > > > week. Please find attached the patches used by us. > > >=20 > > > We were unable to apply the patch3 as it failed with the=20 > > > following error > > >=20 > > > =A0 > > >=20 > > > # patch -p1 < patch3 > > >=20 > > > patching file block/vhdx.c > > >=20 > > > patch: **** malformed patch at line 17:=A0=A0=A0=A0=A0=A0=A0=A0=A0= error_setg_errno(errp, > > > EINVAL, "Image size too large; max of 64TB"); @@ -1936,7 +1936,9= @@ static > > > QemuOptsList vhdx_create_opts =3D { > > >=20 > > > > >=20 > > It looks like however you saved the patch file, it was corrupted. > > Looking at your attached patch 3, it split line 9 across 2 lines. > > Your patch also has whitespace differences from the patch I sent. > >=20 > > You also attached 5 patches - Why are you using patch 0? You should = only be applying patches 1-4. This should not be causing any actual issu= es, however. > > [Amulya]: First time we applied patches 1 to 4, created VHDX image an= d deployed to HyperV Server, but we got the same error. Then we took a fr= esh qemu source and applied patches 0 to 4 and deployed to HyperV and aga= in got the same syntax error. > >=20 > >=20 > > Are you using git for your qemu version? If so, 'git am' is the pref= erred method of applying the patches - just save each of the patch emails= (the whole email should be fine), and run 'git am' on each file. > >=20 > > [Amulya] : No. We don't have a git repository for our team. Could you= please let us know how to apply these patches without git. What is the d= ifference in applying the patch directly and modifying the code directly?= Does it have any impact? > >=20 > > >=20 > > > =A0 > > >=20 > > > Hence, we manually added the patch3 changes and recompiled the q= emu. We > > > then used the patched qemu-img to convert =A0our vmdk image to d= ynamic VHDX > > > format. We found that the image created this time had a consider= able > > > decrease in its size from 50GB to 12GB. > > >=20 > >=20 > > Could you tell me the file size of the VMDK image you were converting= ? > > Is it roughly 12GB as well? > > [Amulya] : No, the vmdk image which we used for conversion is just=20 > > 1.4GB > >=20 > >=20 > > > However, when we deployed it into our SCVMM 2012, the import of = the VHDX > > > image failed with a "syntax error" as below > > >=20 > > > =A0 > > >=20 > > > Information (10804) > > >=20 > > > Unable to import \\Test.com\Library\VHDs\Test-disk1.vhdx because= of a > > > syntax error in the file. > > >=20 > > > =A0 > >=20 > > If you run qemu-img info on Test-disk1.vhdx, what does it say? > >=20 > > [Amulya] : The following is seen with qemu-img info > > # qemu-img info Test-disk1.vhdx > > image: Test-disk1.vhdx > > file format: vhdx > > virtual size: 50G (53687091200 bytes) > > disk size: 3.4G > > cluster_size: 16777216 > >=20 > > The size of our images > > # ls -ltrh > > total 4.8G > > -rw-r--r-- 1 root root 1.4G Dec 9 10:48 Test-disk1.vmdk > > -rw-r--r-- 1 root root 12G Dec 12 04:49 Test-disk1.vhdx > >=20 > > >=20 > > > Please let us know if we missed anything. > > >=20 > > > =A0 > > >=20 > > > Thanks, > > >=20 > > > Amulya > > >=20 > > > =A0 > > > > >=20 > > [...] > >=20 > > Jeff