From: Stefan Hajnoczi <stefanha@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] net: synchronize net_host_device_remove with host_net_remove_completion
Date: Fri, 2 Jan 2015 14:06:58 +0000 [thread overview]
Message-ID: <20150102140658.GL10823@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1419353600-30519-2-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1052 bytes --]
On Tue, Dec 23, 2014 at 05:53:20PM +0100, Paolo Bonzini wrote:
> @@ -324,6 +324,8 @@ void qemu_del_net_client(NetClientState *nc)
> NetClientState *ncs[MAX_QUEUE_NUM];
> int queues, i;
>
> + assert(nc->info->type != NET_CLIENT_OPTIONS_KIND_NIC);
> +
> /* If the NetClientState belongs to a multiqueue backend, we will change all
> * other NetClientStates also.
> */
> @@ -355,8 +357,6 @@ void qemu_del_net_client(NetClientState *nc)
> return;
> }
>
> - assert(nc->info->type != NET_CLIENT_OPTIONS_KIND_NIC);
> -
> for (i = 0; i < queues; i++) {
> qemu_cleanup_net_client(ncs[i]);
> qemu_free_net_client(ncs[i]);
The assert can be dropped completely since the code already has an
equivalent assert:
queues = qemu_find_net_clients_except(nc->name, ncs,
NET_CLIENT_OPTIONS_KIND_NIC,
MAX_QUEUE_NUM);
assert(queues != 0); <-- fail if type == NET_CLIENT_OPTIONS_KIND_NIC
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-01-02 14:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 16:53 [Qemu-devel] [PATCH] net: synchronize net_host_device_remove with host_net_remove_completion Paolo Bonzini
2015-01-02 14:06 ` Stefan Hajnoczi [this message]
2015-01-02 16:20 ` Paolo Bonzini
2015-01-19 11:27 ` Paolo Bonzini
2015-01-28 9:50 ` Paolo Bonzini
2015-02-06 13:54 ` Stefan Hajnoczi
2015-02-06 14:46 ` Paolo Bonzini
2015-02-06 16:51 ` Stefan Hajnoczi
2015-01-29 10:15 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150102140658.GL10823@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).