From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50122) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8Dk2-0005K9-1T for qemu-devel@nongnu.org; Mon, 05 Jan 2015 14:55:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y8Djy-0002Wr-S9 for qemu-devel@nongnu.org; Mon, 05 Jan 2015 14:55:05 -0500 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:58189) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y8Djy-0002TP-Ki for qemu-devel@nongnu.org; Mon, 05 Jan 2015 14:55:02 -0500 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 5 Jan 2015 19:54:59 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id D39361B08040 for ; Mon, 5 Jan 2015 19:55:30 +0000 (GMT) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t05Jswio56754338 for ; Mon, 5 Jan 2015 19:54:58 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t05JsvLV023725 for ; Mon, 5 Jan 2015 12:54:58 -0700 Date: Mon, 5 Jan 2015 20:54:51 +0100 From: Greg Kurz Message-ID: <20150105205451.4d6a0991@bahia.local> In-Reply-To: <1420467812-31917-1-git-send-email-peter.maydell@linaro.org> References: <1420467812-31917-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] include/qom/cpu.h: Add missing documentation for some CPUClass methods List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Jens Freimann , Andreas =?UTF-8?B?RsOkcmJlcg==?= , qemu-devel@nongnu.org, Anthony Liguori , patches@linaro.org On Mon, 5 Jan 2015 14:23:32 +0000 Peter Maydell wrote: > The CPUClass QOM methods virtio_is_big_endian, write_elf{32,64}_note > and write_elf{32,64}_qemunote were added without any description > being added to the doc comment. Correct this omission. > > Signed-off-by: Peter Maydell > --- Thanks for this accurate description of virtio_is_big_endian. Acked-by: Greg Kurz > More informative phrasings for the elf note callbacks welcome... > > include/qom/cpu.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/qom/cpu.h b/include/qom/cpu.h > index 2098f1c..f2d7de1 100644 > --- a/include/qom/cpu.h > +++ b/include/qom/cpu.h > @@ -82,6 +82,10 @@ struct TranslationBlock; > * @do_unassigned_access: Callback for unassigned access handling. > * @do_unaligned_access: Callback for unaligned access handling, if > * the target defines #ALIGNED_ONLY. > + * @virtio_is_big_endian: Callback to return true if a CPU which supports > + * runtime configurable endianness is currently big-endian. Non-configurable > + * CPUs can use the default implementation of this method. This method should > + * not be used by any callers other than the pre-1.0 virtio devices. > * @memory_rw_debug: Callback for GDB memory access. > * @dump_state: Callback for dumping state. > * @dump_statistics: Callback for dumping statistics. > @@ -96,6 +100,14 @@ struct TranslationBlock; > * @gdb_read_register: Callback for letting GDB read a register. > * @gdb_write_register: Callback for letting GDB write a register. > * @debug_excp_handler: Callback for handling debug exceptions. > + * @write_elf64_note: Callback for writing a CPU-specific ELF note to a > + * 64-bit VM coredump. > + * @write_elf32_qemunote: Callback for writing a CPU- and QEMU-specific ELF > + * note to a 32 bit VM coredump. > + * @write_elf32_note: Callback for writing a CPU-specific ELF note to a > + * 32-bit VM coredump. > + * @write_elf32_qemunote: Callback for writing a CPU- and QEMU-specific ELF > + * note to a 32 bit VM coredump. > * @vmsd: State description for migration. > * @gdb_num_core_regs: Number of core registers accessible to GDB. > * @gdb_core_xml_file: File name for core registers GDB XML description.